Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Namjae Jeon" <namjae.jeon@samsung.com>
To:     =?UTF-8?Q?'Pali_Roh=C3=A1r'?= <pali.rohar@gmail.com>
Cc:     <linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
        <gregkh@linuxfoundation.org>, <valdis.kletnieks@vt.edu>,
        <hch@lst.de>, <sj1557.seo@samsung.com>, <linkinjeon@gmail.com>,
        <arnd@arndb.de>
In-Reply-To: <20200115093915.cjef2jadiwe2eul4@pali>
Subject: RE: [PATCH v10 11/14] exfat: add Kconfig and Makefile
Date:   Fri, 17 Jan 2020 13:22:27 +0900
Message-ID: <002f01d5cced$ba0828b0$2e187a10$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Language: ko
Thread-Index: AQHvmPGd9hXZW1JGF9XPkytILTKCmQHO27G6AkKblqwC0Bzdx6eDnHCw
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <20200115082447.19520-1-namjae.jeon@samsung.com>
        <CGME20200115082825epcas1p1f22ddca6dbf5d70e65d3b0e3c25c3a59@epcas1p1.samsung.com>
        <20200115082447.19520-12-namjae.jeon@samsung.com>
        <20200115093915.cjef2jadiwe2eul4@pali>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> > +config EXFAT_DEFAULT_IOCHARSET
> > +	string =22Default iocharset for exFAT=22
> > +	default =22utf8=22
> > +	depends on EXFAT_FS
> > +	help
> > +	  Set this to the default input/output character set you'd
> > +	  like exFAT to use. It should probably match the character set
> > +	  that most of your exFAT filesystems use, and can be overridden
> > +	  with the =22iocharset=22 mount option for exFAT filesystems.
>=20
> Hello=21 This description is incorrect. iocharset option specify what
> character set is expected by VFS layer and not character set used by exFA=
T
> filesystem. exFAT filesystem always uses UTF-16 as this is the only
> allowed by exFAT specification.
Hi Pali,

Could you please review updated description ?

diff --git a/fs/exfat/Kconfig b/fs/exfat/Kconfig
index 9eeaa6d06..f2b0cf2c1 100644
--- a/fs/exfat/Kconfig
+++ b/fs/exfat/Kconfig
=40=40 -15,7 +15,7 =40=40 config EXFAT_DEFAULT_IOCHARSET
        default =22utf8=22
        depends on EXFAT_FS
        help
-         Set this to the default input/output character set you'd
-         like exFAT to use. It should probably match the character set
-         that most of your exFAT filesystems use, and can be overridden
-         with the =22iocharset=22 mount option for exFAT filesystems.
+         Set this to the default input/output character set to use for
+         converting between the encoding is used for user visible filename=
 and
+         UTF-16 character that exfat filesystem use. and can be overridden=
 with
+         the =22iocharset=22 mount option for exFAT filesystems.