Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Namjae Jeon" <namjae.jeon@samsung.com>
To:     "'Arnd Bergmann'" <arnd@arndb.de>
Cc:     "'Namjae Jeon'" <linkinjeon@gmail.com>,
        <linux-kernel@vger.kernel.org>,
        "'Linux FS-devel Mailing List'" <linux-fsdevel@vger.kernel.org>,
        "'gregkh'" <gregkh@linuxfoundation.org>,
        =?UTF-8?Q?'Pali_Roh=C3=A1r'?= <pali.rohar@gmail.com>,
        "'Valdis Kletnieks'" <valdis.kletnieks@vt.edu>,
        "'Christoph Hellwig'" <hch@lst.de>, <sj1557.seo@samsung.com>
In-Reply-To: <CAK8P3a1iYPA9MrXORiWmy1vQGoazwHs7OfPdoHLZLJDWqu9jqA@mail.gmail.com>
Subject: RE: [PATCH v10 09/14] exfat: add misc operations
Date:   Fri, 17 Jan 2020 11:59:29 +0900
Message-ID: <002801d5cce2$228d79f0$67a86dd0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Language: ko
Thread-Index: AQDl4arpJeuFoAiOGgh7zDYNQFC3mAHvmPGdAYS70pMCTZrZ/wIalS1qAZ8YAg8BhDMOogFX8NFhAlVLKr8BX6mCFwHtIwURqT4Yc0A=
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <CGME20200115082824epcas1p4eb45d088c2f88149acb94563c4a9b276@epcas1p4.samsung.com>
        <20200115082447.19520-1-namjae.jeon@samsung.com>
        <20200115082447.19520-10-namjae.jeon@samsung.com>
        <CAK8P3a3Vqz=T_=sFwBBPa2_Hi_dA=BwWod=L9JkLxUgi=aKNWw@mail.gmail.com>
        <CAKYAXd9_qmanQCcrdpScFWvPXuZvk4jhv7Gc=t_vRL9zqWNSjA@mail.gmail.com>
        <20200115133838.q33p5riihsinp6c4@pali>
        <CAK8P3a1ozgLYpDtveU0CtLj5fEFG8i=_QrnEAtoVFt-yC=Dc0g@mail.gmail.com>
        <20200115142428.ugsp3binf2vuiarq@pali>
        <CAK8P3a0_sotmv40qHkhE5M=PwEYLuJfX+uRFZvh9iGzhv6R6vw@mail.gmail.com>
        <20200115153943.qw35ya37ws6ftlnt@pali>
        <CAK8P3a1iYPA9MrXORiWmy1vQGoazwHs7OfPdoHLZLJDWqu9jqA@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

=20
> This is what I think the timezone mount option should be used
> for: if we don't know what the timezone was for the on-disk timestamp, us=
e
> the one provided by the user. However, if none was specified, it should b=
e
> either sys_tz or UTC (i.e. no conversion). I would prefer the use of UTC
> here given the problems with sys_tz, but sys_tz would be more consistent
> with how fs/fat works.
Hi Arnd,

Could you please review this change ?

/* Convert a EXFAT time/date pair to a UNIX date (seconds since 1 1 70). */
void exfat_get_entry_time(struct exfat_sb_info *sbi, struct timespec64 *ts,
                __le16 time, __le16 date, u8 tz)
=7B      =20
        u16 t =3D le16_to_cpu(time);
        u16 d =3D le16_to_cpu(date);
       =20
        ts->tv_sec =3D mktime64(1980 + (d >> 9), d >> 5 & 0x000F, d & 0x001=
F,
                              t >> 11, (t >> 5) & 0x003F, (t & 0x001F) << 1=
);
        ts->tv_nsec =3D 0;
       =20
        if (tz & EXFAT_TZ_VALID)
                /* Adjust timezone to UTC0. */
                exfat_adjust_tz(ts, tz & =7EEXFAT_TZ_VALID);
        else   =20
                /* Convert from local time to UTC using time_offset. */
                ts->tv_sec -=3D sbi->options.time_offset * SECS_PER_MIN;
=7D

/* Convert linear UNIX date to a EXFAT time/date pair. */
void exfat_set_entry_time(struct exfat_sb_info *sbi, struct timespec64 *ts,
                __le16 *time, __le16 *date, u8 *tz)
=7B
        struct tm tm;
        u16 t, d;

        time64_to_tm(ts->tv_sec, 0, &tm);
        t =3D (tm.tm_hour << 11) =7C (tm.tm_min << 5) =7C (tm.tm_sec >> 1);
        d =3D ((tm.tm_year - 80) <<  9) =7C ((tm.tm_mon + 1) << 5) =7C tm.t=
m_mday;

        *time =3D cpu_to_le16(t);
        *date =3D cpu_to_le16(d);

        /*
         * Record 00h value for OffsetFromUtc field and 1 value for OffsetV=
alid
         * to indicate that local time and UTC are the same.
         */
        *tz =3D EXFAT_TZ_VALID;
=7D

Thanks=21