Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [RFT PATCH 0/4] hwmon: k10temp driver improvements
To:     Ken Moffat <zarniwhoop73@googlemail.com>
Cc:     linux-hwmon@vger.kernel.org, Clemens Ladisch <clemens@ladisch.de>,
        Jean Delvare <jdelvare@suse.com>, linux-kernel@vger.kernel.org
References: <20200116141800.9828-1-linux@roeck-us.net>
 <CANVEwpZVZs5gnvQTgwZGcT6JG7WdGrOVpbHWGD08bjPascjL=g@mail.gmail.com>
From:   Guenter Roeck <linux@roeck-us.net>
Message-ID: <964a5977-8d67-b0fd-4df4-c6bd41a8ad58@roeck-us.net>
Date:   Thu, 16 Jan 2020 19:58:12 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <CANVEwpZVZs5gnvQTgwZGcT6JG7WdGrOVpbHWGD08bjPascjL=g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Ken,

On 1/16/20 4:38 PM, Ken Moffat wrote:
> On Thu, 16 Jan 2020 at 14:18, Guenter Roeck <linux@roeck-us.net> wrote:
[ ... ]
> I have some Zen1 and Zen1+ here.
> 
> My Ryzen 3 1300X, applied to 5.5.0-rc5
> 
> machine idle, I thought at first the temperature may be a bit low, so
> I've added other reported temperatures.  I now think it is maybe ok.
> 
> k10temp-pci-00c3
> Adapter: PCI adapter
> Vcore:        +1.41 V
> Vsoc:         +0.89 V
> Tdie:         +21.2°C  (high = +70.0°C)
> Tctl:         +21.2°C
> Icore:       +30.14 A
> Isoc:         +8.66 A
> 
> SYSTIN:                 +29.0°C  (high =  +0.0°C, hyst =  +0.0°C)
> ALARM  sensor = thermistor
> CPUTIN:                 +25.5°C  (high = +80.0°C, hyst = +75.0°C)
> sensor = thermistor
> AUXTIN0:                 -1.5°C    sensor = thermistor
> AUXTIN1:                +87.0°C    sensor = thermistor
> AUXTIN2:                +23.0°C    sensor = thermistor
> AUXTIN3:                -27.0°C    sensor = thermistor
> SMBUSMASTER 0:          +20.5°C
> 
SMBUSMASTER 0 is the CPU, so we have a match with the temperatures.

> After about 2 minutes of make -j8 on kernel, to load it
> 
> k10temp-pci-00c3
> Adapter: PCI adapter
> Vcore:        +1.26 V
> Vsoc:         +0.89 V
> Tdie:         +46.2°C  (high = +70.0°C)
> Tctl:         +46.2°C
> Icore:       +45.73 A
> Isoc:        +11.18 A
> 

Both Vcore and Icore should be much less when idle, and higher under
load. The data from the Super-IO chip suggests that it is a Nuvoton
chip. Can you report its first voltage (in0) ? That should roughly
match Vcore.

> SYSTIN:                 +29.0°C  (high =  +0.0°C, hyst =  +0.0°C)
> ALARM  sensor = thermistor
> CPUTIN:                 +38.5°C  (high = +80.0°C, hyst = +75.0°C)
> sensor = thermistor
> AUXTIN0:                 -7.5°C    sensor = thermistor
> AUXTIN1:                +85.0°C    sensor = thermistor
> AUXTIN2:                +23.0°C    sensor = thermistor
> AUXTIN3:                -27.0°C    sensor = thermistor
> SMBUSMASTER 0:          +46.0°C
> 
> So I guess the temperatures *are* in the right area.
> Interestingly, the Vcore restores to above +1.4V when idle.
> 
It should be much lower when idle, actually, not higher.

All other data looks ok.

Thanks,
Guenter