Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 17 Jan 2020 10:12:45 +0100
From:   Pali =?utf-8?B?Um9ow6Fy?= <pali.rohar@gmail.com>
To:     Namjae Jeon <namjae.jeon@samsung.com>
Cc:     linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        gregkh@linuxfoundation.org, valdis.kletnieks@vt.edu, hch@lst.de,
        sj1557.seo@samsung.com, linkinjeon@gmail.com, arnd@arndb.de
Subject: Re: [PATCH v10 11/14] exfat: add Kconfig and Makefile
Message-ID: <20200117091245.ginzffry7anqofju@pali>
References: <20200115082447.19520-1-namjae.jeon@samsung.com>
 <CGME20200115082825epcas1p1f22ddca6dbf5d70e65d3b0e3c25c3a59@epcas1p1.samsung.com>
 <20200115082447.19520-12-namjae.jeon@samsung.com>
 <20200115093915.cjef2jadiwe2eul4@pali>
 <002f01d5cced$ba0828b0$2e187a10$@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <002f01d5cced$ba0828b0$2e187a10$@samsung.com>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Friday 17 January 2020 13:22:27 Namjae Jeon wrote:
> > > +config EXFAT_DEFAULT_IOCHARSET
> > > +	string "Default iocharset for exFAT"
> > > +	default "utf8"
> > > +	depends on EXFAT_FS
> > > +	help
> > > +	  Set this to the default input/output character set you'd
> > > +	  like exFAT to use. It should probably match the character set
> > > +	  that most of your exFAT filesystems use, and can be overridden
> > > +	  with the "iocharset" mount option for exFAT filesystems.
> > 
> > Hello! This description is incorrect. iocharset option specify what
> > character set is expected by VFS layer and not character set used by exFAT
> > filesystem. exFAT filesystem always uses UTF-16 as this is the only
> > allowed by exFAT specification.
> Hi Pali,
> 
> Could you please review updated description ?
> 
> diff --git a/fs/exfat/Kconfig b/fs/exfat/Kconfig
> index 9eeaa6d06..f2b0cf2c1 100644
> --- a/fs/exfat/Kconfig
> +++ b/fs/exfat/Kconfig
> @@ -15,7 +15,7 @@ config EXFAT_DEFAULT_IOCHARSET
>         default "utf8"
>         depends on EXFAT_FS
>         help
> -         Set this to the default input/output character set you'd
> -         like exFAT to use. It should probably match the character set
> -         that most of your exFAT filesystems use, and can be overridden
> -         with the "iocharset" mount option for exFAT filesystems.
> +         Set this to the default input/output character set to use for
> +         converting between the encoding is used for user visible filename and
> +         UTF-16 character that exfat filesystem use. and can be overridden with
> +         the "iocharset" mount option for exFAT filesystems.

Hello! This is much better. Fine for me.

-- 
Pali Rohár
pali.rohar@gmail.com