Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 17 Jan 2020 02:20:30 -0800 (PST)
Message-Id: <20200117.022030.458227945074641961.davem@davemloft.net>
To:     liuyonglong@huawei.com
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        linuxarm@huawei.com, salil.mehta@huawei.com,
        jakub.kicinski@netronome.com
Subject: Re: [PATCH net] net: hns: fix soft lockup when there is not enough
 memory
From:   David Miller <davem@davemloft.net>
In-Reply-To: <1579160477-31030-1-git-send-email-liuyonglong@huawei.com>
References: <1579160477-31030-1-git-send-email-liuyonglong@huawei.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Yonglong Liu <liuyonglong@huawei.com>
Date: Thu, 16 Jan 2020 15:41:17 +0800

> When there is not enough memory and napi_alloc_skb() return NULL,
> the HNS driver will print error message, and than try again, if
> the memory is not enough for a while, huge error message and the
> retry operation will cause soft lockup.
> 
> When napi_alloc_skb() return NULL because of no memory, we can
> get a warn_alloc() call trace, so this patch deletes the error
> message. We already use polling mode to handle irq, but the
> retry operation will render the polling weight inactive, this
> patch just return budget when the rx is not completed to avoid
> dead loop.
> 
> Fixes: 36eedfde1a36 ("net: hns: Optimize hns_nic_common_poll for better performance")
> Fixes: b5996f11ea54 ("net: add Hisilicon Network Subsystem basic ethernet support")
> Signed-off-by: Yonglong Liu <liuyonglong@huawei.com>

Applied and queued up for -stable.