Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp8867743ybl; Fri, 17 Jan 2020 02:30:25 -0800 (PST) X-Google-Smtp-Source: APXvYqz7CynYMof+VT3TRFQ3WZ3btRVwV8hwoVAoIswhmRZMn49mWYprwzeFH/31cDrvm2FIAzel X-Received: by 2002:a05:6808:2c4:: with SMTP id a4mr2806732oid.22.1579257025706; Fri, 17 Jan 2020 02:30:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579257025; cv=none; d=google.com; s=arc-20160816; b=AMA4SuC4BcyGoKTe17LuUC/a21gA7jQG1S4rqR6B5OLeYbp4NmhGjNuwFabqTUl9Af VxglstwG7pkK9yMoPgCG8VJtP3VMSdcrBtCNH/GbOMwLzt6ILFPDRjgwgsZ5wHcNzxoW VZtH73rRGhsBXYn5KmT0vFnjf2Qaj2KtbewbtMQn92OC1YKz+KewV0EfNUpKs8eNtgq6 UCEivg0o61rC9/F9WjLKo/GUxQcQ8hCpoOWdMMyWRAVD6YnxhEwQfJgMbCFFkeL0+DRl e0uhLo57VKlrX8X58ofCHRB0ABsxvPuGetkadfw8C0ZFyfmJvG3UgAp5zG686t6zqvzD GmHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=NBw6IaCm/MpM55YRUrvj6NCZYaCidWTdV8Sqmqgjx8c=; b=zfSWTzXkLg7nUBFiICV3xw73dsTEyQs2JGnnvZiCYovuwHrDAwp1Tyxn0M8YahZfnM kpxEcdY50TWQU+tlVflzSHhrnDwr1B4zh/UuWhvVhcNVrQNORuNj/ZlV/rKdasaY74Oo /9QQaa3kTX5YYePTZ3D4tqz1T5kO5S+kI1O/EjD1N2rtKQlmiFN2ODYnQL7SEWCnLwcl 35gh7pB7dsCiGqqJa63fPVAzYSV46ZR3dO4yj3ie++SBpSbOXJjjtb5IBawCymYHnO7X ZQ3++OhcNjyqPdmoKeCsF0h/cOHpvdunPsulW8Te3A2/sVsA53tYwERxuN2NBbrstCgS F1tQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e73si13323427oib.145.2020.01.17.02.30.14; Fri, 17 Jan 2020 02:30:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727003AbgAQK2W (ORCPT + 99 others); Fri, 17 Jan 2020 05:28:22 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:48904 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726085AbgAQK2W (ORCPT ); Fri, 17 Jan 2020 05:28:22 -0500 Received: from localhost (82-95-191-104.ip.xs4all.nl [82.95.191.104]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 771A2155CB083; Fri, 17 Jan 2020 02:28:19 -0800 (PST) Date: Fri, 17 Jan 2020 02:28:17 -0800 (PST) Message-Id: <20200117.022817.1170708716212895346.davem@davemloft.net> To: yaohongbo@huawei.com Cc: kuba@kernel.org, chenzhou10@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 -next] drivers/net: netdevsim depends on INET From: David Miller In-Reply-To: <20200116131404.169423-1-yaohongbo@huawei.com> References: <20200116131404.169423-1-yaohongbo@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 17 Jan 2020 02:28:20 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hongbo Yao Date: Thu, 16 Jan 2020 21:14:04 +0800 > If CONFIG_INET is not set and CONFIG_NETDEVSIM=y. > Building drivers/net/netdevsim/fib.o will get the following error: > > drivers/net/netdevsim/fib.o: In function `nsim_fib4_rt_hw_flags_set': > fib.c:(.text+0x12b): undefined reference to `fib_alias_hw_flags_set' > drivers/net/netdevsim/fib.o: In function `nsim_fib4_rt_destroy': > fib.c:(.text+0xb11): undefined reference to `free_fib_info' > > Correct the Kconfig for netdevsim. > > Reported-by: Hulk Robot > Fixes: 48bb9eb47b270 ("netdevsim: fib: Add dummy implementation for FIB offload") > Signed-off-by: Hongbo Yao Applied, thanks.