Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200104122217.148883-1-dor.askayo@gmail.com>
In-Reply-To: <20200104122217.148883-1-dor.askayo@gmail.com>
From:   Dor Askayo <dor.askayo@gmail.com>
Date:   Fri, 17 Jan 2020 12:59:39 +0200
Message-ID: <CAO80jNS795mgHCp3XedZQ1o1QHbwxb8DeuSqPtKHmKbAVYsfmg@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/display: do not allocate display_mode_lib unnecessarily
To:     amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org,
        Alex Deucher <alexander.deucher@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>
Cc:     Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
        "David (ChunMing) Zhou" <David1.Zhou@amd.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Jan 4, 2020 at 2:23 PM Dor Askayo <dor.askayo@gmail.com> wrote:
>
> This allocation isn't required and can fail when resuming from suspend.
>
> Bug: https://gitlab.freedesktop.org/drm/amd/issues/1009
> Signed-off-by: Dor Askayo <dor.askayo@gmail.com>
> ---
>  drivers/gpu/drm/amd/display/dc/core/dc.c | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index dd4731ab935c..83ebb716166b 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -2179,12 +2179,7 @@ void dc_set_power_state(
>         enum dc_acpi_cm_power_state power_state)
>  {
>         struct kref refcount;
> -       struct display_mode_lib *dml = kzalloc(sizeof(struct display_mode_lib),
> -                                               GFP_KERNEL);
> -
> -       ASSERT(dml);
> -       if (!dml)
> -               return;
> +       struct display_mode_lib *dml;
>
>         switch (power_state) {
>         case DC_ACPI_CM_POWER_STATE_D0:
> @@ -2206,6 +2201,12 @@ void dc_set_power_state(
>                  * clean state, and dc hw programming optimizations will not
>                  * cause any trouble.
>                  */
> +               dml = kzalloc(sizeof(struct display_mode_lib),
> +                               GFP_KERNEL);
> +
> +               ASSERT(dml);
> +               if (!dml)
> +                       return;
>
>                 /* Preserve refcount */
>                 refcount = dc->current_state->refcount;
> @@ -2219,10 +2220,10 @@ void dc_set_power_state(
>                 dc->current_state->refcount = refcount;
>                 dc->current_state->bw_ctx.dml = *dml;
>
> +               kfree(dml);
> +
>                 break;
>         }
> -
> -       kfree(dml);
>  }
>
>  void dc_resume(struct dc *dc)
> --
> 2.24.1
>

I've been running with this fix applied on top of Fedora's
5.3.16-300.fc31.x86_64 kernel for
the past two weeks, suspending and resuming often. This the first time
since I bought my
RX 580 8GB more than a year ago that I can suspend and resume reliably.

I'd appreciate a quick review for the above, it really is a trivial change.

Thanks,
Dor