Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp8929387ybl; Fri, 17 Jan 2020 03:36:04 -0800 (PST) X-Google-Smtp-Source: APXvYqyGQQ3krHvfZhk9cSdoouD3S7fRtNBErlm41Gd8WdxPQ0xG7oapWrxc5i+npscqTaMHOa4e X-Received: by 2002:a9d:4c82:: with SMTP id m2mr5789410otf.199.1579260964156; Fri, 17 Jan 2020 03:36:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579260964; cv=none; d=google.com; s=arc-20160816; b=gvAsMpNRHs2gvW8X883VNkFB5irsiTqmPfQ1NwP6prWgXpSUFg456XRgfMu8BRU+hD /dVpHMKI3lhZLvZWfIsvVdMS6eEf99Fl4Nt4f2odOWPKREe0QjOBAKqeGevyUdsAbokr 8oBHXI8711Ta9dk6/N8yGv38sU3fgX0G767fZyfW7m26KVH80ZYf9igdM1j09moMZmlX ESBCViAmXpbI7DrgoqgqLy1HPOLn3OktPMTtNsiEPsmJtK4D6RFBLE2UMH2ynN6OzSsT /zGd7acEkRwlAmUvFF0uca4eVlIA8iVk5BIII/P8EWlBwGdlaMRtBRYXpEPoMxzDinml +AyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=evNHCWWR8VDQgkVk+W1DMeAHVIxkJQGWyaVBPtYnDrc=; b=EIN1rdIHcCjnqDQFmpVEMKQ+1d7MEI0HwjpU2FjqYcIMPZO4JtUu0vqxLUjNzyabJE qGE0xIQPfALIUw5B1pN09jTmFI6ztuyVMXXe2eT6Y0Q4GQvmDEOKlZnMdQ9cZ31lPtp0 BygKHg5Wb09RdWZJ3NShmRVijGWod2gANJCG9VxNMdxpN9eVYzE9EqGDJvM1GXW6mSMN m8r5EZ3wYdzS9zlyQsumeRxVwC6cWQqAPP2DZvlEZbuVeGUNY4tIGcuv9T9Q2ALDpjXS fMYhtd2PI/E5s/s2dZvY+QK2Jil1oEebqAi9qpDFLKDW72sEWKd6QA/tC2vdLj/c916j KB1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=oBGOm9Jv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z14si14141857oth.15.2020.01.17.03.35.51; Fri, 17 Jan 2020 03:36:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=oBGOm9Jv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726973AbgAQLe6 (ORCPT + 99 others); Fri, 17 Jan 2020 06:34:58 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:43647 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726371AbgAQLe5 (ORCPT ); Fri, 17 Jan 2020 06:34:57 -0500 Received: by mail-wr1-f68.google.com with SMTP id d16so22376891wre.10 for ; Fri, 17 Jan 2020 03:34:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=evNHCWWR8VDQgkVk+W1DMeAHVIxkJQGWyaVBPtYnDrc=; b=oBGOm9JvQ2c/xRqP4pTi1fYT4Xeumb+8oGfQHcf95V0670qJ/7pQ7y3K2WG7YtLHNr VyjVpgrZFjiUcr8izrBXeqTrurwr6KnbGdtcbzwhRXGj5tHqowSJogHYzEWuicTLKVlI XPdZBH5SApp7zifRAvPMp23HYM2ZCB2mnYCHb4MA+iWYjA40RXVo4rIZvjdqK9SxJRGt EnISdUOZNFjodtS6vvsGwC24f38bRxelB2c6jbM+MVlj0gtS9KtCIyvlyvgw7FjvyIv8 6sDFWcWIKeuo0wrRqSv0bJy5m3N3iftgPM9U7u3/05jsbtJ045OCH2Hd4Vq+C1l1fEpL PDdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=evNHCWWR8VDQgkVk+W1DMeAHVIxkJQGWyaVBPtYnDrc=; b=WFYoATpS4O+0JuUI7mtuqB2UCYYSZqU0f1wmMP3curdzarIIUcFPWN5F8nxlb6SJWz Ll8LeqWmGkJk5N98VK0bL0tMz8mV9fCUo8CBhuGlr/sDNYuM0WXNW13rjgp+r2leHbKI /ozcIKjDZJ5qfVdtEat747GJXF6YP+um+2TlsA4TwWs9/RQwnRDUsTiJoirUzuBLH32m QZ6sV4hb2NiGABXiylwO4Jyk2zuHJy3cTz6Usz1uklx6Jsx0QuRaO43hljNOMH55ZqDw Sca4Ju9NQrVd2TnaH96SlPqjFQglq/p5oFBnwy21fmfC98rKcBx59A6AuaJQf4X4hWaC w0tA== X-Gm-Message-State: APjAAAXp9Ts/Qm0SIu0WpWPr2UI7VfJP8s11Lj6xCiMiF1FqnC7EGxT6 3PWxPrMPQLODe1GTCxcA910fuQ== X-Received: by 2002:adf:fe12:: with SMTP id n18mr2784294wrr.158.1579260896233; Fri, 17 Jan 2020 03:34:56 -0800 (PST) Received: from dell ([2.27.35.221]) by smtp.gmail.com with ESMTPSA id 60sm34545482wrn.86.2020.01.17.03.34.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jan 2020 03:34:55 -0800 (PST) Date: Fri, 17 Jan 2020 11:35:11 +0000 From: Lee Jones To: Prashant Malani Cc: enric.balletbo@collabora.com, groeck@chromium.org, bleung@chromium.org, sre@kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v7 2/3] mfd: cros_ec: Add cros-usbpd-notify subdevice Message-ID: <20200117113511.GJ15507@dell> References: <20200117002820.56872-1-pmalani@chromium.org> <20200117002820.56872-2-pmalani@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200117002820.56872-2-pmalani@chromium.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Jan 2020, Prashant Malani wrote: > Add the cros-usbpd-notify driver as a subdevice on platforms that > support the EC_FEATURE_USB_PD EC feature flag and don't have the > ACPI PD notification device defined. > > This driver allows other cros-ec devices to receive PD event > notifications from the Chrome OS Embedded Controller (EC) via a > notification chain. > > Reviewed-by: Benson Leung > Signed-off-by: Prashant Malani > --- > > Changes in v7: > - No changes. > > Changes in v6: > - No changes. > > Changes in v5: > - Updated the IS_ENABLED() check to check for CONFIG_OF instead of > !CONFIG_ACPI according to upstream comments. > > Changes in v4: > - Removed #ifndef usage; instead, moved cros-usbpd-notify to a separate > mfd_cell and used an IS_ENABLED() check. > - Changed commit title and description slightly to reflect change in > code. > > drivers/mfd/cros_ec_dev.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) Applied v6, since Patchwork can pick-up the Acks and there haven't been any changes since then. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog