Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20200117091813.wiksrz5khmtoocbj@pali>
References: <20200115082447.19520-1-namjae.jeon@samsung.com>
 <CGME20200115082821epcas1p4d76d8668dfac70ae3e3889d4ccb6c3ee@epcas1p4.samsung.com>
 <20200115082447.19520-6-namjae.jeon@samsung.com> <20200117091813.wiksrz5khmtoocbj@pali>
From:   Namjae Jeon <linkinjeon@gmail.com>
Date:   Fri, 17 Jan 2020 20:12:26 +0800
Message-ID: <CAKYAXd9mcsZYp_EuPx_5KACW7oPvtTmWmxHgCsy1PgOZskJjyg@mail.gmail.com>
Subject: Re: [PATCH v10 05/14] exfat: add file operations
To:     =?UTF-8?Q?Pali_Roh=C3=A1r?= <pali.rohar@gmail.com>
Cc:     Namjae Jeon <namjae.jeon@samsung.com>,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        gregkh@linuxfoundation.org, valdis.kletnieks@vt.edu, hch@lst.de,
        sj1557.seo@samsung.com, arnd@arndb.de
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

2020-01-17 17:18 GMT+08:00, Pali Roh=C3=A1r <pali.rohar@gmail.com>:
> On Wednesday 15 January 2020 17:24:38 Namjae Jeon wrote:
>> This adds the implementation of file operations for exfat.
>>
>> Reviewed-by: Christoph Hellwig <hch@lst.de>
>> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
>> Signed-off-by: Sungjong Seo <sj1557.seo@samsung.com>
>> ---
>>  fs/exfat/file.c | 355 ++++++++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 355 insertions(+)
>>  create mode 100644 fs/exfat/file.c
>>
>> diff --git a/fs/exfat/file.c b/fs/exfat/file.c
>> new file mode 100644
>> index 000000000000..b4b8af0cae0a
>> --- /dev/null
>> +++ b/fs/exfat/file.c
>
> ...
>
>> +/* resize the file length */
>> +int __exfat_truncate(struct inode *inode, loff_t new_size)
>> +{
>
> ...
>
>> +
>> +		ktime_get_real_ts64(&ts);
>> +		exfat_set_entry_time(sbi, &ts,
>> +				&ep->dentry.file.modify_time,
>> +				&ep->dentry.file.modify_date,
>> +				&ep->dentry.file.modify_tz);
>
> Hello! Now I spotted that you forgot to update "modify_time_ms" entry.
Good catch:)
>
> To prevent this problem, maybe function modify_time_ms() could take
> another (optional) parameter for specifying time_ms?
Okay, I will change exfat_set/get_entry_time to take a time_ms argument.
Thanks for your review!