Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp8994124ybl; Fri, 17 Jan 2020 04:41:41 -0800 (PST) X-Google-Smtp-Source: APXvYqxq7/oZvvR/tQF3LHNENkaxxLi74lwiN9mdNnTEnjyL987aCvfa2I4fu6jjY0J/myWl2zBR X-Received: by 2002:a54:4715:: with SMTP id k21mr3249937oik.163.1579264901488; Fri, 17 Jan 2020 04:41:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579264901; cv=none; d=google.com; s=arc-20160816; b=usoErqsoeuWPztcp8c//SFJaa1IgRKDwUlx7Pr38yayPWG3bgWXFL7GHf6Ineb7W9n 87/LQFuvxVo07orGCWkRpOFJ4QA2JHtLrpp+95pRpVpW1VxH+hkOUt8u6+3mGoyJXHOO l8VHq9QQmrKGW8yHZC0uUx0kvDbd74Kx1aYnC0X3smTXixqq5Xy5+pAFNe6dakrQ/k2S pcx7+CohYS0RmyGhNMcsi3vOITS9yZDXG2hLBt3uW+j79MvPOR7SkmLbe9z6wUmK3NQH GdORjZLe371PFV+t+ts5Cbqsl3Jqyp607XmPQQy51diydPpr39fOLBl8vfv+LI/mf4ic 3k6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:in-reply-to:cc:references:message-id :date:subject:mime-version:from:content-transfer-encoding :dkim-signature; bh=EEYzszKyIEcUSg4iqz8XJMBTQPM568jpucE6cSO2l/U=; b=mnBfGZTCvgu9WBa2vNaYt/zLnFqPOi+tDy1KCdmo/FkPX5JmQpgZn+3eOwdPsVDkOl 2+GPHKJBZRq6Q7A8zHKi6IOqSmdHOgAwz5/LKm9p20CZswOgwUfYjREYmMLp4o3Zab6m B92sjQcDKilg/7jWdFxXtzOID/Pd7t/6ZMGZBNGxI06X/DmS+0vsRaSDMpEZoUOGhn3P 3Lh8YHKqPDtnFISR6x0O7glF2lHQ+a2gTESQS4ZE9e+8UOrfX6vSO+mcP5gwKV36b0fv WEhilQTGYb4MEybpTNc1gVO4hbkyH3k/5aZZjIX7K4ZLx5YHjDmN/4Ti5Hs6lxoq64Lm 1zKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lca.pw header.s=google header.b=evk1J7dh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m24si14652350otn.67.2020.01.17.04.41.28; Fri, 17 Jan 2020 04:41:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@lca.pw header.s=google header.b=evk1J7dh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727003AbgAQMkS (ORCPT + 99 others); Fri, 17 Jan 2020 07:40:18 -0500 Received: from mail-qv1-f50.google.com ([209.85.219.50]:46614 "EHLO mail-qv1-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726329AbgAQMkS (ORCPT ); Fri, 17 Jan 2020 07:40:18 -0500 Received: by mail-qv1-f50.google.com with SMTP id u1so10600462qvk.13 for ; Fri, 17 Jan 2020 04:40:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=EEYzszKyIEcUSg4iqz8XJMBTQPM568jpucE6cSO2l/U=; b=evk1J7dhPrnQM4qt0qwrFduRec8uyXznMMQKil6cinRTO+JJTAVXMKaw1qJD+PVHa+ i0pyYtX/WQ0OAB4STCEQt1JODVxRHLTKAGzwICxbI1wNie5+GmxI17yhpYjwG5WqSXQ8 1zMeF/2IWWaNZK3jy/j2lFzH6KrCqxWGE0W1AesqhYadj4/E8yrhHVXrJTnKyD5CcOft PZ01dFELmQNzLRj/poE5bk9etGYpcDM8/qKg3rLKfb7cdWavl+qWSwxfI34zSfyWz9eQ Mrb8VWqOHSF9wbGufmywdzwvENLE82rVcDH2NxzWbXSooyfIe0tOQhUdfCwD07B1TKuP HcgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=EEYzszKyIEcUSg4iqz8XJMBTQPM568jpucE6cSO2l/U=; b=oQCSMje5BPu8vUNqQendesBNQ0/yyloiL9awO2E2ad9HTIdiWOthg/hxPeXisQFh9D PY6WDh2oDEvnNgun9OC2DX4MpBFO5OqniSBRHdF1p7yU4f5HsAvWHl6UNAK2ldtmaLFV 8icjL+wZjZdKz8p279EbsjpIJE0AC7VAMBx2KpKcLkd/bzMuob/FAQs2R76mIuJ2QQF0 ayUwGaGpuH3xtN+ov/AdnVWhOwv6x8TKfI8tAEbWRLhTSDD1Hh80lvM1dqQrHGqw2uDQ 2dM+dRaWcYiiEK3vKyI/SLuvUR9CL6vLUWeIQUbpHLSSYS65tHjJO3jQkyqyeZh/0o28 bhnA== X-Gm-Message-State: APjAAAWYa2f2KvlVu2NOcms4EbU6GD/V2/SEy5IvakWocUEZIaJPUHJv mFw+rmBDlUFeIpOe838ueCzCDEsw3yfu8Q== X-Received: by 2002:ad4:50d2:: with SMTP id e18mr7622075qvq.9.1579264817318; Fri, 17 Jan 2020 04:40:17 -0800 (PST) Received: from [192.168.1.183] (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id e2sm11582651qkl.3.2020.01.17.04.40.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jan 2020 04:40:16 -0800 (PST) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable From: Qian Cai Mime-Version: 1.0 (1.0) Subject: Re: [PATCH -next v4] mm/hotplug: silence a lockdep splat with printk() Date: Fri, 17 Jan 2020 07:40:15 -0500 Message-Id: <6BED7E12-CC3B-4AED-ACC8-F3533D3F3C70@lca.pw> References: Cc: akpm@linux-foundation.org, mhocko@kernel.org, sergey.senozhatsky.work@gmail.com, pmladek@suse.com, rostedt@goodmis.org, peterz@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko In-Reply-To: To: David Hildenbrand X-Mailer: iPhone Mail (17C54) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Jan 17, 2020, at 3:51 AM, David Hildenbrand wrote: >=20 > -> you are accessing the pageblock without the zone lock. It could > change to "isolate" again in the meantime if I am not wrong! Since we are just dumping the state for debugging, it should be fine to acce= pt a bit inaccuracy here due to racing. I could put a bit comments over ther= e.=