Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1579031859-18692-1-git-send-email-thara.gopinath@linaro.org>
 <1579031859-18692-5-git-send-email-thara.gopinath@linaro.org>
 <20200116151502.GQ2827@hirez.programming.kicks-ass.net> <20200117114045.GA219309@google.com>
 <20200117123103.GB14879@hirez.programming.kicks-ass.net>
In-Reply-To: <20200117123103.GB14879@hirez.programming.kicks-ass.net>
From:   Vincent Guittot <vincent.guittot@linaro.org>
Date:   Fri, 17 Jan 2020 14:17:36 +0100
Message-ID: <CAKfTPtALUU7SRmyU=u6-fxa8dkNWFrxE59JfYh+TmiDCqf0Kqg@mail.gmail.com>
Subject: Re: [Patch v8 4/7] sched/fair: Enable periodic update of average
 thermal pressure
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Quentin Perret <qperret@google.com>,
        Thara Gopinath <thara.gopinath@linaro.org>,
        Ingo Molnar <mingo@redhat.com>,
        Ionela Voinescu <ionela.voinescu@arm.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Zhang Rui <rui.zhang@intel.com>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        viresh kumar <viresh.kumar@linaro.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Amit Kachhap <amit.kachhap@gmail.com>,
        Javi Merino <javi.merino@kernel.org>,
        Amit Kucheria <amit.kucheria@verdurent.com>,
        Android Kernel Team <kernel-team@android.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 17 Jan 2020 at 13:31, Peter Zijlstra <peterz@infradead.org> wrote:
>
> On Fri, Jan 17, 2020 at 11:40:45AM +0000, Quentin Perret wrote:
> > On Thursday 16 Jan 2020 at 16:15:02 (+0100), Peter Zijlstra wrote:
> > > > @@ -10275,6 +10281,7 @@ static void task_tick_fair(struct rq *rq, struct task_struct *curr, int queued)
> > > >  {
> > > >   struct cfs_rq *cfs_rq;
> > > >   struct sched_entity *se = &curr->se;
> > > > + unsigned long thermal_pressure = arch_cpu_thermal_pressure(cpu_of(rq));
> > > >
> > > >   for_each_sched_entity(se) {
> > > >           cfs_rq = cfs_rq_of(se);
> > > > @@ -10286,6 +10293,7 @@ static void task_tick_fair(struct rq *rq, struct task_struct *curr, int queued)
> > > >
> > > >   update_misfit_status(curr, rq);
> > > >   update_overutilized_status(task_rq(curr));
> > > > + update_thermal_load_avg(rq_clock_task(rq), rq, thermal_pressure);
> > > >  }
> > >
> > > I'm thinking this is the wrong place; should this not be in
> > > scheduler_tick(), right before calling sched_class::task_tick() ? Surely
> > > any execution will affect thermals, not only fair class execution.
> >
> > Right, but right now only CFS takes action when we overheat. That is,
> > only CFS uses capacity_of() which is where the thermal signal gets
> > reflected.
>
> Sure, but we should still track the thermals unconditionally, even if
> only CFS consumes it.

I agree, tracking thermal pressure should happen even if no cfs task are running

>
> > We definitely could (and maybe should) make RT and DL react to thermal
> > pressure as well when they're both capacity-aware. But perhaps that's
> > for later ? Thoughts ?
>
> Yeah, that's later head-aches. Even determining what to do there, except
> panic() is going to be 'interesting'.