Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp9083957ybl;
        Fri, 17 Jan 2020 06:08:12 -0800 (PST)
X-Google-Smtp-Source: APXvYqyvKRaBh2gbPK/E4jBXebXjyYL/O/ON04celjLaxxEGN7ZpO//e5al/6GD9RGkJA/dfg1Ic
X-Received: by 2002:aca:b1d5:: with SMTP id a204mr3415697oif.82.1579270092426;
        Fri, 17 Jan 2020 06:08:12 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1579270092; cv=none;
        d=google.com; s=arc-20160816;
        b=ZUlLXrBTXINI769R7k54VZ02YElWrT2OIEVUfHOwlE4+zaVapZCrfr4Vh0YaeDqnv4
         CoTd9xCSn0gIfPzyzSPumAi+/CCqlcP5JaaqADRVHmuJ7pQ7lplWX2qCCYD8c85jKNl6
         PeWVbjim7W/pAsFimm/sp91b6CgOW5VzWsOTsDPEdCd2bleJeVG34eh+BW3knyV0NwWQ
         Y28AJdkFryTr4PN3H5vjST/K0Dt994YtyO0baolMaAwYq2O/T04D+4VidKfHzJTyhSXX
         doWgQYPCD6Qtfi0T0LIrcIzkDoa2PvLtI4sQBqD//8cYfWuhCz0bZp6cVTw8VQRuK5Nx
         hciA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:to:references:message-id
         :content-transfer-encoding:cc:date:in-reply-to:from:subject
         :mime-version;
        bh=sLywWU+5WtUUEFM3LT3MVITKUK90bFDJpWfXOLhrgXA=;
        b=CbDvUySjHvPuRxbJJjzeJQbmOn5GmmMFKb+BWPUj5gAE/8cvx464FPb/6WVCE8MtK6
         hfMHUIN5P0HhEjtvEgAbsaM9Fyx6vgljNheLNogWAAjOaFPkKzq0tvNnaGtwoz/R12B5
         7PvbP2YP4IrN1TUEbtnCqPtkeNBHursaSL5ds8Ca9AtWdIG+FNCzdPyZDJLVjp7QBO4Z
         O0+VnnQCVn6vAnVGx54hd5MCbS8G9xvAHKUCVTmyPfGw/9DLKjfFjMTBkwrrumRhk5/x
         CTXjPaQo3iPTXaZg7ElTfhvE8RTgQASqJ2JrmbmRWPiPoxk794ug80vaylsKRKUFTNv1
         6Ouw==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id c2si16558352oto.207.2020.01.17.06.07.59;
        Fri, 17 Jan 2020 06:08:12 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727667AbgAQOGX convert rfc822-to-8bit (ORCPT
        <rfc822;ablacktshirt@gmail.com> + 99 others);
        Fri, 17 Jan 2020 09:06:23 -0500
Received: from out30-130.freemail.mail.aliyun.com ([115.124.30.130]:41037 "EHLO
        out30-130.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1726587AbgAQOGX (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 17 Jan 2020 09:06:23 -0500
X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01f04446;MF=gerry@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0TnywUgP_1579269963;
Received: from 127.0.0.1(mailfrom:gerry@linux.alibaba.com fp:SMTPD_---0TnywUgP_1579269963)
          by smtp.aliyun-inc.com(127.0.0.1);
          Fri, 17 Jan 2020 22:06:08 +0800
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Subject: Re: [PATCH v1 1/2] x86/msi: Enhance x86 to support platform_msi
From:   "Liu, Jiang" <gerry@linux.alibaba.com>
In-Reply-To: <874kwu2nih.fsf@nanos.tec.linutronix.de>
Date:   Fri, 17 Jan 2020 22:06:01 +0800
Cc:     Zha Bin <zhabin@linux.alibaba.com>, linux-kernel@vger.kernel.org,
        "Michael S. Tsirkin" <mst@redhat.com>, jasowang@redhat.com,
        slp@redhat.com, virtio-dev@lists.oasis-open.org,
        jing2.liu@intel.com, chao.p.peng@intel.com
Content-Transfer-Encoding: 8BIT
Message-Id: <80399081-6B8F-405D-BD6B-572206F0CCEB@linux.alibaba.com>
References: <874kwu2nih.fsf@nanos.tec.linutronix.de>
To:     Thomas Gleixner <tglx@linutronix.de>
X-Mailer: Apple Mail (2.3445.104.11)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



> On Jan 17, 2020, at 9:58 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> 
> Zha Bin <zhabin@linux.alibaba.com> writes:
> 
>> From: Liu Jiang <gerry@linux.alibaba.com>
>> 
>> The x86 platform currently only supports specific MSI/MSI-x for PCI
>> devices. To enable MSI to the platform devices such as virtio-mmio
>> device, this patch enhances x86 with platform MSI by leveraging the
>> already built-in platform-msi driver (drivers/base/platform-msi.c)
>> and makes it as a configurable option.
> 
> Why are you trying to make this an architecture feature instead of
> having a generic implementation which can work on all architectures
> which support virtio-mmio?
Thanks, Thomas!
We are reworking to implement it as a generic irqdomain for all virtio MMIO devices.

> 
>> Signed-off-by: Liu Jiang <gerry@linux.alibaba.com>
>> Signed-off-by: Zha Bin <zhabin@linux.alibaba.com>
>> Signed-off-by: Chao Peng <chao.p.peng@linux.intel.com>
>> Signed-off-by: Jing Liu <jing2.liu@linux.intel.com>
> 
> This Signed-off-by chain is invalid.
> 
> Thanks,
> 
>        tglx