Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp9147261ybl; Fri, 17 Jan 2020 07:06:29 -0800 (PST) X-Google-Smtp-Source: APXvYqxnJL6uLY8FDcDPzXZQ8eFLZhrojLygI4hx4jHdRN0sa7a2djPcN6XOh0GUcDbo8hPtNFQR X-Received: by 2002:a54:4501:: with SMTP id l1mr3513701oil.101.1579273589494; Fri, 17 Jan 2020 07:06:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579273589; cv=none; d=google.com; s=arc-20160816; b=0YGedLr7EWglwxHIjPGE+/RZYR8HOKJNcsDCCrwqBuZTo4MWUlnMu5oLwCdtar5Bf8 Xx2oceAvW3L07707Ci5sgVUGTsvRjLFH9HXhDRPJvsUTDreClIyjNzc9qnTbIOgyfQiq eI92Dwka3/4VHcLa8lKP3ZV4LZQFs5S5a/sL71ba2OoBL3NvZOR1zArQvQacq61oLERw XqpZQ66mwppkxSy1NT55f2Kx5aZY4nMoIym+lHI3mRKHo5p+sUNZHrfMIz6UgbtAT0NB IlboP7vjaFOAVLnZC8mLXJNcYBajAvFwS56jlxcfqhvkxGLxJh99fW335EH8O+9o/qlK Gm2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=LOaIeI56K/aCDv5goc4mOWfpn44YF+CHC57xuZ2OvQE=; b=VcD3zOlfzuRVuUWqQHJy/DM6Y016LhTzxwTSe8+OExFdPP/q/LjJn7Ci/2MAXvLe25 pXc98iezRJ6bSZbM5mJvIgCZ3GTqmzhnway9T2KEUDAVhpzoujFPeDcWzwgi1LzWir5j hfVE9zJm5nqpytw4zHhAveoRAIOLw9Zwv6IPi0hIiBUciF39JOWbG4DoxK8cw8FaqLe+ 4K1oFX3UesgDpGhGF3k3BOermA5Hh0khu0e61IYsihqqC661Auh59QimUdT93AmpLaJc eo+2NWc2uPAjlVbEaun0OABUqPlCxrAhPobVR/OgivSjKhxmXlvhUCvEPf8IBqc/yT/y Qnrg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 17si13636708oix.22.2020.01.17.07.06.17; Fri, 17 Jan 2020 07:06:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729158AbgAQPEC (ORCPT + 99 others); Fri, 17 Jan 2020 10:04:02 -0500 Received: from mx2.suse.de ([195.135.220.15]:46182 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729073AbgAQPD6 (ORCPT ); Fri, 17 Jan 2020 10:03:58 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 10BA1BBAB; Fri, 17 Jan 2020 15:03:57 +0000 (UTC) From: Petr Mladek To: Jiri Kosina , Josh Poimboeuf , Miroslav Benes Cc: Joe Lawrence , Kamalesh Babulal , Nicolai Stange , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Petr Mladek Subject: [POC 06/23] livepatch: Enable the livepatch submodule Date: Fri, 17 Jan 2020 16:03:06 +0100 Message-Id: <20200117150323.21801-7-pmladek@suse.com> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20200117150323.21801-1-pmladek@suse.com> References: <20200117150323.21801-1-pmladek@suse.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The final step when loading livepatch module for livepatching a module is to actually enable the livepatch. The steps are exactly the same as in kmp_module_comming(). Note that there is no need to call klp_cleanup_module_patches_limited() in the error path. klp_add_object() modifies only the single matching struct klp_patch. Signed-off-by: Petr Mladek --- kernel/livepatch/core.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c index 6c27b635e5a7..c21bd9ec2012 100644 --- a/kernel/livepatch/core.c +++ b/kernel/livepatch/core.c @@ -1011,6 +1011,28 @@ int klp_add_object(struct klp_object *obj) goto err_free; } + pr_notice("applying patch '%s' to loading module '%s'\n", + patch->obj->patch_name, obj->name); + + ret = klp_pre_patch_callback(obj); + if (ret) { + pr_warn("pre-patch callback failed for object '%s'\n", + obj->name); + goto err_free; + } + + ret = klp_patch_object(obj); + if (ret) { + pr_warn("failed to apply patch '%s' to module '%s' (%d)\n", + patch->obj->patch_name, obj->name, ret); + + klp_post_unpatch_callback(obj); + goto err_free; + } + + if (patch != klp_transition_patch) + klp_post_patch_callback(obj); + mutex_unlock(&klp_mutex); return 0; -- 2.16.4