Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp9149943ybl; Fri, 17 Jan 2020 07:08:47 -0800 (PST) X-Google-Smtp-Source: APXvYqyK0MWSuSJPLYmK+3NLv919Is0NXw36vjRL4jjHV4Kl/2wORLh+dTzdHOJnRKw2C7zcjxYo X-Received: by 2002:aca:4183:: with SMTP id o125mr3486468oia.125.1579273727128; Fri, 17 Jan 2020 07:08:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579273727; cv=none; d=google.com; s=arc-20160816; b=dufCsH6ih1M9k1wJagSx41kxSYU9OLgnYWPsdXyLwP8HkhyeAttZCKe6FDsbTHVvla yDIqTTTz9Y8ximfm9ITV3Gj3ukmoY1K9743XHsy61lJUq3OhkA70u5+/LlBHDqC/efgs FZ8G9tocjqwL6LCtc8bOeqbKcPQslOWaIKcOMAmSJWcfCuFX5mJOZ/v8KlSCq3UmjihJ xg9Mq672JHCPSQKC72Ac5sJHQD+ngJ5BckXC3JGi4YHA3eyapeSx+FyuMYCNmTZUfLpA bddXnQXR8wG0JdRhP1WRG/jKDmSS/yauQPh9yHDGTvJ1RH7IXYBoQzTr1bvRvTA+NyKx c76w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:in-reply-to:cc:references:message-id :date:subject:mime-version:from:content-transfer-encoding :dkim-signature; bh=vEWn2SOFLnhk6DlGp/dtE96pkDjAj01HAVf7nAH98+Y=; b=FsQvSBuenDeYXR8mm6ynKIUbpHY6VjVnSbzHrSCqzPUnyOyuStHnUj5+Xv1ayky3J+ 4ENW6EFiwzIBPqpueZ3GtMtosHvwC12yV/8Wlqysm2sH5t1NqxJjJLhknIuTasm9n5by PztzkgtdVQ2rzN0UdFQ9zc6uLesw7+9dXlIfV16yYBlUMrQ11vPyiS4RyU2egULvXhHo pV7BwkBobzXkrNxm3x1R3qveS+W8FRav+cnmZ7oIbUjIOY2p74Ho5q4EChys3RTnnSEk 3EuXh29uLLKhZU5riCGZC683mKrfoRqIf1vqiftxdziSJBZXVNrlvveFcQafGYIl6opu /wcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lca.pw header.s=google header.b=UdczXrlr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n8si15257265otr.102.2020.01.17.07.08.34; Fri, 17 Jan 2020 07:08:47 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@lca.pw header.s=google header.b=UdczXrlr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729503AbgAQPFQ (ORCPT + 99 others); Fri, 17 Jan 2020 10:05:16 -0500 Received: from mail-qk1-f175.google.com ([209.85.222.175]:43526 "EHLO mail-qk1-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728927AbgAQPFP (ORCPT ); Fri, 17 Jan 2020 10:05:15 -0500 Received: by mail-qk1-f175.google.com with SMTP id t129so22926363qke.10 for ; Fri, 17 Jan 2020 07:05:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=vEWn2SOFLnhk6DlGp/dtE96pkDjAj01HAVf7nAH98+Y=; b=UdczXrlrHa7YI7hXuVCGuYq3iIBXYbq7STlxmX5/IEAtQp12ssQdMaOaEmXiRwLDnO aFG08He1ZOznOu+u9WwwmvxBEPi2O9Ops3pGHITFG7sh+sP1/bs42HruOwufQWsEHIi8 IWfeEymTVvG56MvshgmDAQwmvYpdezVUWJGliYS+1ARlknRvdGKWEIJmlZNmNevnrW0o qRmtV4dIeyJz/sjyxQamX4g4nAzELTcBVo8MA1biGJILF703GtWjbGoxinQ7GwYI3MQY q0L11M2vOjTJvE22s2zKWDbjkSdn9m5aC98Bkt1cipcz+5hVxG6+F2t9w6rsX2l+qXKn IvyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=vEWn2SOFLnhk6DlGp/dtE96pkDjAj01HAVf7nAH98+Y=; b=Prv5UnnR9sqgPNvFJj1ETJXTRi8c7rSbd/pkgnCHrkuHQFPvj4lr7HcKKbgrDYlgRL xO9tvXzHd/cn9E9RpT4o7EoBUgPx5retMvQO89SzJqnbTWYOjlRhg/fSlpwND3JfuWhp +3xQaWF638pTdxb/1GLTGFxf4m/F1WKYA2PJRELyJ2ib3VjV3SdxTdH5u2X3wPAqM9D6 g0nLH/Lms0FjmsEdEIkj1BnHWZzNVlMKg4cfIGeA30aLl77py0armz0lSyoHVV1SO1fc 5gKcBSvLR5PCNkSCw+DWlFjY+NzuMM7VX3iUG6zI74SD6cY+bPQ19ROvZ4R66iOmdkMd ZKOQ== X-Gm-Message-State: APjAAAXImLF2UfcyFyeu2FvTLmiTA3gpmnGxT633X0C1KK2fdsHNLfL4 h5gaHg0lTAavWN8n8KVQfMg45VIpDbkOJg== X-Received: by 2002:a05:620a:1030:: with SMTP id a16mr37042858qkk.1.1579273513798; Fri, 17 Jan 2020 07:05:13 -0800 (PST) Received: from [172.16.31.141] ([209.104.239.146]) by smtp.gmail.com with ESMTPSA id d26sm11693722qka.28.2020.01.17.07.05.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jan 2020 07:05:12 -0800 (PST) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable From: Qian Cai Mime-Version: 1.0 (1.0) Subject: Re: [PATCH -next v4] mm/hotplug: silence a lockdep splat with printk() Date: Fri, 17 Jan 2020 10:05:12 -0500 Message-Id: <3B7490FB-E915-4DC7-8739-01EDC023E22E@lca.pw> References: <20200117143905.GZ19428@dhcp22.suse.cz> Cc: akpm@linux-foundation.org, sergey.senozhatsky.work@gmail.com, pmladek@suse.com, rostedt@goodmis.org, peterz@infradead.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org In-Reply-To: <20200117143905.GZ19428@dhcp22.suse.cz> To: Michal Hocko X-Mailer: iPhone Mail (17C54) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Jan 17, 2020, at 9:39 AM, Michal Hocko wrote: >=20 > Thanks a lot. Having it in a separate patch would be great. I was thinking about removing that WARN together in this v5 patch, so there i= s less churn to touch the same function again. However, I am fine either way= , so just shout out if you feel strongly towards a separate patch.=