Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp9189414ybl; Fri, 17 Jan 2020 07:45:40 -0800 (PST) X-Google-Smtp-Source: APXvYqyyP26yYFLvfr5arYgBL/HeKHSPfKuTKY538vmTNjaxSMjqlfVUJV+Myd1hhuKttGCoIOeq X-Received: by 2002:a9d:6510:: with SMTP id i16mr6303718otl.142.1579275940653; Fri, 17 Jan 2020 07:45:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579275940; cv=none; d=google.com; s=arc-20160816; b=PD0IdEspiYvFC5baTwwvqZAfT9KnEYPGhkNqZF2dVA8xuKgtuFQcRoJ7YHqqdHYsBr Zjox+EN0CNZI8bqMJ4oHLnf70lBV2/d9+FHWdat37xPm/h7NL03Fp6ttloQTKG4pCyx8 PYjJdFdqyv96BCk1qeSXcr5daTbzHNBXoWUqVrVTOapVR3HUaxJx4JmLFtfxpJdhsNNC wpsxcLPXl7YGu6t1kFztAlfnZfKbB0CgYEYmsrZy4O6EUkeAd3n1jnXPW0Z8RvTAVIt5 IX2tP7OIDBNCiWtE0TedOQAHtmnnwJUDIT+nXQZg/IMGjHzBMwPtXkvzwSSAzbl6RjlH D7IA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:in-reply-to:subject:cc:to :from:dkim-signature; bh=YLlnZQ7obo9hm7ntSycOnGTHd4uSo2u5L5NqtVkSEhU=; b=wsWdWu7G16hUtglvISfBlE1iipA6W4nTRxrkorvXTmVZleOtovgupMNvnlMjw5mi5X U813a1hsB9EWTw1eGAzxda/mGjjW+Vq5Db55SRqDofrDOO3ZkJ3EL9LIVCaOJfj+Zeca c49Bvr/9e0WE0vsVfM3dmelZhX+Z3rLFKlYW0gGCg+PEQEzA9vw0kdnQSM78ka7XWRge vZzanXR0MVocITpalTNR1iTvwoVierP8wYe+nL5oOVkpEvLkTxHHJ1CVKRyeOkHDgA03 t5g5ECYdh/dy4B06D74H+AI/QAACI1mZshasx/kxIZp5Q5pfRtHMLWEDGPZgnkEQSeYz 3EBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=vlNXxdig; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x3si13879510oic.251.2020.01.17.07.45.28; Fri, 17 Jan 2020 07:45:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=vlNXxdig; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729248AbgAQPoa (ORCPT + 99 others); Fri, 17 Jan 2020 10:44:30 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:53708 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728916AbgAQPoW (ORCPT ); Fri, 17 Jan 2020 10:44:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=YLlnZQ7obo9hm7ntSycOnGTHd4uSo2u5L5NqtVkSEhU=; b=vlNXxdigELV6 g+TmlfBvaYktTTmvTvB6lO2W01Mpb4sLJoFC4eT8H1IX+DWWgMIyZYRF9NlCFLurMoewuBxZNMCZj ENwui7VJMvxkrKTb25IdXUylDXd9EAoxHsIFp/5e3UqL4qr8BnMVFHJ7AS8HK0m42A8LQOcPuPAEU r0bMo=; Received: from fw-tnat-cam4.arm.com ([217.140.106.52] helo=fitzroy.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1isTnA-0006s0-1O; Fri, 17 Jan 2020 15:44:12 +0000 Received: by fitzroy.sirena.org.uk (Postfix, from userid 1000) id B1237D02BD9; Fri, 17 Jan 2020 15:44:11 +0000 (GMT) From: Mark Brown To: Wei Yongjun Cc: alsa-devel@alsa-project.org, Bard Liao , Jack Yu , Jaroslav Kysela , kernel-janitors@vger.kernel.org, Liam Girdwood , linux-kernel@vger.kernel.org, Mark Brown , Oder Chiou , Takashi Iwai Subject: Applied "ASoC: rt715: fix return value check in rt715_sdw_probe()" to the asoc tree In-Reply-To: <20200117024149.75515-1-weiyongjun1@huawei.com> Message-Id: X-Patchwork-Hint: ignore Date: Fri, 17 Jan 2020 15:44:11 +0000 (GMT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch ASoC: rt715: fix return value check in rt715_sdw_probe() has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.6 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From f9f5bbf5783cd63369d3e6c8cf27e2bd7c5ac2c3 Mon Sep 17 00:00:00 2001 From: Wei Yongjun Date: Fri, 17 Jan 2020 02:41:49 +0000 Subject: [PATCH] ASoC: rt715: fix return value check in rt715_sdw_probe() In case of error, the function devm_regmap_init() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: d1ede0641b05 ("ASoC: rt715: add RT715 codec driver") Signed-off-by: Wei Yongjun Link: https://lore.kernel.org/r/20200117024149.75515-1-weiyongjun1@huawei.com Signed-off-by: Mark Brown --- sound/soc/codecs/rt715-sdw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/rt715-sdw.c b/sound/soc/codecs/rt715-sdw.c index 18868e4ae6e8..6d892c44c522 100644 --- a/sound/soc/codecs/rt715-sdw.c +++ b/sound/soc/codecs/rt715-sdw.c @@ -535,8 +535,8 @@ static int rt715_sdw_probe(struct sdw_slave *slave, regmap = devm_regmap_init(&slave->dev, NULL, &slave->dev, &rt715_regmap); - if (!regmap) - return -EINVAL; + if (IS_ERR(regmap)) + return PTR_ERR(regmap); rt715_init(&slave->dev, sdw_regmap, regmap, slave); -- 2.20.1