Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [Patch v8 7/7] sched/fair: Enable tuning of decay period
To:     Quentin Perret <qperret@google.com>
References: <1579031859-18692-1-git-send-email-thara.gopinath@linaro.org>
 <1579031859-18692-8-git-send-email-thara.gopinath@linaro.org>
 <20200117114758.GB219309@google.com>
Cc:     mingo@redhat.com, peterz@infradead.org, ionela.voinescu@arm.com,
        vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
        rui.zhang@intel.com, daniel.lezcano@linaro.org,
        viresh.kumar@linaro.org, linux-kernel@vger.kernel.org,
        amit.kachhap@gmail.com, javi.merino@kernel.org,
        kernel-team@android.com
From:   Thara Gopinath <thara.gopinath@linaro.org>
Message-ID: <5E21D6AC.4020502@linaro.org>
Date:   Fri, 17 Jan 2020 10:45:48 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <20200117114758.GB219309@google.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 01/17/2020 06:47 AM, Quentin Perret wrote:
> On Tuesday 14 Jan 2020 at 14:57:39 (-0500), Thara Gopinath wrote:
>> +static int __init setup_sched_thermal_decay_shift(char *str)
>> +{
>> +	int _shift;
>> +
>> +	if (kstrtoint(str, 0, &_shift))
>> +		pr_warn("Unable to set scheduler thermal pressure decay shift parameter\n");
> 
> Nit: looking at kstrtoint() it seems that _shift will be left unmodified
> upon failure. To avoid feeding a random value to clamp() below, perhaps
> initialize _shift to 0 ?

You are right. I will fix it. Thanks!
> 
>> +	sched_thermal_decay_shift = clamp(_shift, 0, 10);
>> +	return 1;
>> +}
> 
> Thanks,
> Quentin
> 


-- 
Warm Regards
Thara