Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp9260476ybl; Fri, 17 Jan 2020 08:55:20 -0800 (PST) X-Google-Smtp-Source: APXvYqxSd31w/1g2wmUEsD829ERwErsQP5Nx8SELR7/LMqbDdJ+CL5i8aU3K+QRporPO5RrIf0k1 X-Received: by 2002:a9d:da2:: with SMTP id 31mr6633424ots.319.1579280120601; Fri, 17 Jan 2020 08:55:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579280120; cv=none; d=google.com; s=arc-20160816; b=GAVzYtmwm2rFNP3PJLSnLXnB02gzgb17/xQFWlLlSfuARz/+gtwRXU8OTkhAwCMrdo IPsjUiLf12p0J+U765Bhbxjj8vxrd4ARNaiIMTQiQkw0P0s4AKT7ojkZwfEjw/PMUFzN nY5nlJpOVVHdWemd+Jc6blmtOV4CDfiREYT8XMB2iQUeZr9zEJzoPNrsyMMFUi7YNh4b 3fvPrUaKbpGdkMoo8LlTyGTXpt3azJu86bpjLTNCnNi6r5sijbBxGqRSlRxTKbwSWsWQ M7PAQ0Cg0J+StPbvzNMjR11Sq7IMLdNK63OMOgw2UPhhtG2Letolszh10xX1arW6SAOW EfsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=1KcWFDl4eqilL13uDZpARQDkQqhvDEx00o7TJlVN14M=; b=DqCeyiY4xiHyajtqh+aKvFFxJp/HTHC37lSdtK6CeJEy4YPl7DMFyRo/L/X1ncrgHA e93Wvx3TueBF0GfQh7qt571eC/+9mBtpVzLxJZvH77cHk2kqkYLDpyuKfwlEcpt0PBy9 6ybtaTF/43gQ9/dF4vbt64PcyweeEHvr4a7oJqqlHR8uwDB0OMI2G7iciX1/7G6dbzc0 e6FZQbo11nd51EzPUN1ELFgiyjWE3pfPHO/rhHx24NFwisybGshDshRxVK7jJdM7d3FO 9G3dw2DXJczQRwcNXfgR2ZzdTo32bjo4njDyqW6ltxIQF3zxRnlm0CPhErCtjyCyGRFJ bE1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="h/bI+vGE"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x3si13766173oie.146.2020.01.17.08.55.09; Fri, 17 Jan 2020 08:55:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="h/bI+vGE"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729222AbgAQQyJ (ORCPT + 99 others); Fri, 17 Jan 2020 11:54:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:55494 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726761AbgAQQyI (ORCPT ); Fri, 17 Jan 2020 11:54:08 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E707E2072B; Fri, 17 Jan 2020 16:54:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579280048; bh=FY97BvRPdZSU2bIodwF411p0zZgZzBz9rfMfxvBV0Po=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=h/bI+vGEPuRESvXvSwPWfqllyNprA4S2VpVi05U+yn/41OeA6M8TqCcjjGvANG2T6 qKcr4mkabYVo+s7BEgvHEJaAM3nXhf4dcUU61v2p7+/vbrThg6BIJKWysCwmLgYxbJ BZeZqz5mUOjt05bV5SwjEkcqRFNXcpvA24WMsDrs= Date: Fri, 17 Jan 2020 17:54:06 +0100 From: Greg KH To: Andi Kleen Cc: roman.sudarikov@linux.intel.com, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com, namhyung@kernel.org, linux-kernel@vger.kernel.org, eranian@google.com, bgregg@netflix.com, kan.liang@linux.intel.com, alexander.antonov@intel.com Subject: Re: [PATCH v4 2/2] perf =?iso-8859-1?Q?x86?= =?iso-8859-1?Q?=3A_Exposing_an_Uncore_unit_to_PMON_for_Intel_Xeon?= =?iso-8859-1?Q?=AE?= server platform Message-ID: <20200117165406.GA1937954@kroah.com> References: <20200117133759.5729-1-roman.sudarikov@linux.intel.com> <20200117133759.5729-3-roman.sudarikov@linux.intel.com> <20200117141944.GC1856891@kroah.com> <20200117162357.GK302770@tassilo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200117162357.GK302770@tassilo.jf.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 17, 2020 at 08:23:57AM -0800, Andi Kleen wrote: > > I thought I was nice and gentle last time and said that this was a > > really bad idea and you would fix it up. That didn't happen, so I am > > being explicit here, THIS IS NOT AN ACCEPTABLE FILE OUTPUT FOR A SYSFS > > FILE. > > Could you suggest how such a 1:N mapping should be expressed instead in > sysfs? I have yet to figure out what it is you all are trying to express here given a lack of Documentation/ABI/ file :) But again, sysfs is ONE VALUE PER FILE. You have a list of items here, that is bounded only by the number of devices in the system at the moment. That number will go up in time, as we all know. So this is just not going to work at all as-is. greg k-h