Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp9338082ybl; Fri, 17 Jan 2020 10:13:31 -0800 (PST) X-Google-Smtp-Source: APXvYqyPoRGI5Eaf3OU6YK1i5VxYAAvTLH4deVvu9qJTtnuksnlCNxQHHFmiTWLEQlADHY0+Ioi9 X-Received: by 2002:a05:6830:1e37:: with SMTP id t23mr7217825otr.16.1579284810999; Fri, 17 Jan 2020 10:13:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579284810; cv=none; d=google.com; s=arc-20160816; b=Fl1mi3h9PVaZgJJ7W5XEQct9lJFU1ITXBUwCQHK/P+G1gQ1fLWMY4nX4oJ6gA1dYgs /ChUmyYBSe/KlL2AUNQX7NJlgduL54GJZ9Qq/Uplc750m4uMHznMXURp9dF3KOabHJ29 D8mBVypRxtY1XB0gBgo0IqKvFHYdgjioTm6Aktj+eExqriGTsBPOt+8K2i/Nw0ivY2Ac 0mMxZojuQT7jZ3iXI4IZfGvxgl7HC5XWoyQ8AWt8ZH0rtV3xYX1Kd8675RTQigxUhWdf b4xy/aCEXbMi2fOGwIXJxk9lsuqV32HPajF9QhtUOUWqCl1vjbVFpd/4caYjlMLztvg/ CJZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=IdyrMy2nrlmfkVGDIpnIS4HjWOBUiobj0MXhdDTQd80=; b=mPDqBCzqhLy2FsI+b+u8StlBJYfbGdxjxXnhuOCHDoMO9TzupWkHSr875rdcpO/Y8K Ux3XY4aiANxoBAOrVmeVTH/CXe7y7GgoanDPpJA2tNTWKn2rfVHLSzVEjXZChPSSPGMg U9SJ+L5JV/aQy63P32+qdjDqOmsBU5YzS9Sza5RiMaDEmC/1djmTYX59XcA4U7BhV8x3 6YMhFpK3mmeRLql1ktMjkmA+AsRD6dR3DtXUMCspzKXhRChVClb5QhS2lJI/6nrJSokK 2LGibzcU49iSvZnF2Z8lpBAUsH7+jo6KBP5xfgfj+Ae28lpeteN5B+CEZ9PDQaY5C6ri zV4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=qn8SJYF+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e192si13668298oib.82.2020.01.17.10.13.19; Fri, 17 Jan 2020 10:13:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=qn8SJYF+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729232AbgAQSMY (ORCPT + 99 others); Fri, 17 Jan 2020 13:12:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:47388 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726603AbgAQSMX (ORCPT ); Fri, 17 Jan 2020 13:12:23 -0500 Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CE02220748; Fri, 17 Jan 2020 18:12:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579284743; bh=IdyrMy2nrlmfkVGDIpnIS4HjWOBUiobj0MXhdDTQd80=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qn8SJYF+AS+5NobYCLPOms9TMfbOAaRLKRT/vF9O3TGrTA/TSz2xio4FkapxEPz75 ddlusE4o2/5Y5ESlOgi6OjeXsjycbBuHKF0v1wIePlD9F9K4cLQ30MncZqSa7pMBI2 naGnJwDelSv6i33seCm+qy64/LRjP4yCKeXIGxo0= Date: Fri, 17 Jan 2020 19:12:20 +0100 From: Maxime Ripard To: Chen-Yu Tsai Cc: Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dts: sun8i: a83t: Fix incorrect clk and reset macros for EMAC device Message-ID: <20200117181220.biryjou5zvqfxdnt@gilmour.lan> References: <20200114094252.8908-1-wens@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bzobas6k7fsnitoh" Content-Disposition: inline In-Reply-To: <20200114094252.8908-1-wens@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --bzobas6k7fsnitoh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jan 14, 2020 at 05:42:52PM +0800, Chen-Yu Tsai wrote: > From: Chen-Yu Tsai > > When the raw numbers used for clk and reset indices in the EMAC device > node were converted to the new macros, the order of the clk and reset > properties was overlooked, and thus the incorrect macros were used. > This results in the EMAC being non-responsive, as well as an oops due > to incorrect usage of the reset control. > > Correct the macro types, and also reorder the clk and reset properties > to match all the other device nodes. > > Fixes: 765866edb16a ("ARM: dts: sunxi: Use macros for references to CCU clocks") > Signed-off-by: Chen-Yu Tsai Queued as a fix for 5.6, thanks! Maxime --bzobas6k7fsnitoh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXiH5BAAKCRDj7w1vZxhR xaaXAQDsG2aEO1qdNIVRhFZfwLaBsqA68VlRWQyNaM9q4IclmgEApgHG16xb1DWI RSmavsHC0ZQmsOTVpBI4SiaME4t3qw0= =cMS9 -----END PGP SIGNATURE----- --bzobas6k7fsnitoh--