Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.40.2.2.4\))
Subject: Re: [PATCH -next v4] mm/hotplug: silence a lockdep splat with
 printk()
From:   Qian Cai <cai@lca.pw>
In-Reply-To: <20200117154657.GL19428@dhcp22.suse.cz>
Date:   Fri, 17 Jan 2020 13:49:53 -0500
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        pmladek@suse.com, rostedt@goodmis.org, peterz@infradead.org,
        david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <00155F33-17C6-4051-A8F9-CCD9414F400D@lca.pw>
References: <20200117143905.GZ19428@dhcp22.suse.cz>
 <3B7490FB-E915-4DC7-8739-01EDC023E22E@lca.pw>
 <20200117154657.GL19428@dhcp22.suse.cz>
To:     Michal Hocko <mhocko@kernel.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On Jan 17, 2020, at 10:46 AM, Michal Hocko <mhocko@kernel.org> wrote:
>=20
> On Fri 17-01-20 10:05:12, Qian Cai wrote:
>>=20
>>=20
>>> On Jan 17, 2020, at 9:39 AM, Michal Hocko <mhocko@kernel.org> wrote:
>>>=20
>>> Thanks a lot. Having it in a separate patch would be great.
>>=20
>> I was thinking about removing that WARN together in this v5 patch,
>> so there is less churn to touch the same function again. However, I
>> am fine either way, so just shout out if you feel strongly towards a
>> separate patch.
>=20
> I hope you meant moving rather than removing ;). The warning is useful
> because we shouldn't see unmovable pages in the movable zone. And a
> separate patch makes more sense because the justification is slightly
> different. We do not want to have a way for userspace to trigger the
> warning from userspace - even though it shouldn't be possible, but
> still. Only the offlining path should complain.

Something like this?

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 621716a25639..32c854851e1f 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -8307,7 +8307,6 @@ struct page *has_unmovable_pages(struct zone =
*zone, struct page *page,
        }
        return NULL;
 unmovable:
-       WARN_ON_ONCE(zone_idx(zone) =3D=3D ZONE_MOVABLE);
        return pfn_to_page(pfn + iter);
 }
=20
diff --git a/mm/page_isolation.c b/mm/page_isolation.c
index e70586523ca3..08571b515d9f 100644
--- a/mm/page_isolation.c
+++ b/mm/page_isolation.c
@@ -54,9 +54,11 @@ static int set_migratetype_isolate(struct page *page, =
int migratetype, int isol_
=20
 out:
        spin_unlock_irqrestore(&zone->lock, flags);
+
        if (!ret)
                drain_all_pages(zone);
        else if ((isol_flags & REPORT_FAILURE) && unmovable)
+               WARN_ON_ONCE(zone_idx(zone) =3D=3D ZONE_MOVABLE);
                /*
                 * printk() with zone->lock held will guarantee to =
trigger a
                 * lockdep splat, so defer it here.=