Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp9408143ybl; Fri, 17 Jan 2020 11:27:42 -0800 (PST) X-Google-Smtp-Source: APXvYqwbytVf9xxd86BsuhpBXZkL/OZ3g3Pbq4964Vn3hzMMQ4elhsRmcFlM5SMCsctCH0njgPes X-Received: by 2002:a05:6830:ce:: with SMTP id x14mr7383647oto.105.1579289262825; Fri, 17 Jan 2020 11:27:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579289262; cv=none; d=google.com; s=arc-20160816; b=oqQngi+Ykx1zGANJv1yW3ks0myuSnYp82jn5JVc5yNoYmw+pKIHwyqIJbSq83bvoRM yrtuI7vLyVe8hwDB8/DSUYmAVPqg2CSA95tB+T7NZmx7H7liXXEO+1AqbZvYgIqX+5Z+ tFYD27jfRl4cO9jmjkwKWC/V4gADoLOZ9y5eDl5UlLZp6oKRy5dqgTFaG7Q+pRjPP8/I 3+hBm/5sTNcTuUTTlXv7tHoanT29dsVwEET97qFH1LeF16L+Ze1mooKrQiDBYWZf9nQm TwDq7tRyTuDQTsfswseCl93CWqtXg80Gor++9m/Q71Mj+uterZKTcUsfaptI+h/GQUxo vcZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:date:from:dkim-signature; bh=CrQQQJS6hPBOvSxXvrnAqrRK6fwLt7e2C0voH4SKr0k=; b=AkoOrVJdwdYXi1prSl99TFsxgCJ6uE3NCY4Wq+jijPyq0Iu6XBFnSnsycr13/eY56O I/wxJZZLRyqPiwZ5peXKR3ZtEvn2QTUQuADf+jHwG6NPbPN+8Kz+VAwRGZUOnJQr9+Yl EDinv3/rsoVhuwCRuS7ebPcLgl+0Rix9ikE7PvU2JputCf5anrHD+1fAleIjAKpOicF2 xLynxvt6iC3m6wGnE71GH4IQNPdJbl9s3PY9pb0EXkFuL1gXYX4yFd/MZVDB8sDQvVCG KvuhjsdXwvficonUvRjyJ35KgKvKkoRV99hAu6xYAWKhDVMJ33u6Ixkl/GkgEs6qGzZm cXAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=fahfwsIR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y8si13792896oih.141.2020.01.17.11.27.30; Fri, 17 Jan 2020 11:27:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=fahfwsIR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729425AbgAQT02 (ORCPT + 99 others); Fri, 17 Jan 2020 14:26:28 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:39567 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726897AbgAQT01 (ORCPT ); Fri, 17 Jan 2020 14:26:27 -0500 Received: by mail-wm1-f67.google.com with SMTP id 20so8748537wmj.4 for ; Fri, 17 Jan 2020 11:26:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=CrQQQJS6hPBOvSxXvrnAqrRK6fwLt7e2C0voH4SKr0k=; b=fahfwsIRCL5XcTiGfHpb3xGA0wah3PeuQkVPJ+bnXWvwF8ZLPAyRVZUvCSuRWwP4Cj ur0GAKBTlTRdpHIREQ8aSuOXyNpFoPb6iE8otT46i3QXIef0/J5iI5oexgHOY6JogqYV 3GPSBxNVU08D0HYXxxzvYLIyiv5W/XDutH95CdP9gcTdXmm9UE91QnYTF/U+3deBcB2N rpH/zmemra+IW4ovEzPmp8On7ZJ+HLghcYzgYrBYqHRnYovG8ekFuubY11ikbpKvZpEs 2Ct3BRmqAPvR/21AB9XSSyN14ruV9V0eWn2mf+x9AaBQAx3zHabOT4rx3HnBNZHFgIzX GLQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=CrQQQJS6hPBOvSxXvrnAqrRK6fwLt7e2C0voH4SKr0k=; b=f/k/6fGVwMSLkxSiz2gMfg/64lfudf2x0xz6qvNVg+ndrawVLhn19PanzoItOrecmv 2KBl2O0yMAxlaeo0mb6Fe4Dtk1VuLW8v17RuFvWEc6+USmpCuSMPQrNsoxhzawuf6RYD sv1fbfkKNbeB+Wk38DobxXfji/j+ZDBhvES194ODBTUsqkERvJ8WXu6H7V853Nq4we5/ hCuhtSJVVDLC/AMTff4NyA4l48x62afydRatFg3HEuH9s9thaYMo8KZjW80Gi3kqUX1F bWUXZ7zQFFRrCUehgv59/yr7z64l19gqspYsZ8QLvhH0WO4MNiYKVBuEyBOk/o1wBowO rKng== X-Gm-Message-State: APjAAAXa4p0jkmZI6OPs5TjgIt0H0Y9VQei6/AAChQ17/4NrYSnmvf5Y dc4+fGzwSRVuKidfgbokcWI= X-Received: by 2002:a1c:a78c:: with SMTP id q134mr6234664wme.98.1579289185316; Fri, 17 Jan 2020 11:26:25 -0800 (PST) Received: from wambui.local ([197.237.61.225]) by smtp.googlemail.com with ESMTPSA id q11sm35636991wrp.24.2020.01.17.11.26.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jan 2020 11:26:24 -0800 (PST) From: Wambui Karuga X-Google-Original-From: Wambui Karuga Date: Fri, 17 Jan 2020 22:25:44 +0300 (EAT) To: Jani Nikula cc: Wambui Karuga , joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, airlied@linux.ie, daniel@ffwll.ch, sean@poorly.run, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/4] drm/i915/display: conversion to new logging macros. In-Reply-To: <87pnfigpi5.fsf@intel.com> Message-ID: References: <20200116130947.15464-1-wambui.karugax@gmail.com> <87pnfigpi5.fsf@intel.com> User-Agent: Alpine 2.21.99999 (LNX 375 2019-10-29) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 17 Jan 2020, Jani Nikula wrote: > On Thu, 16 Jan 2020, Wambui Karuga wrote: >> This series converts the printk based logging macros in >> drm/i915/display/intel_display.c to the new struct drm_device based >> logging macros. This change was split into four for manageability and >> due to the size of drm/i915/display/intel_display.c. > > Please still write more descriptive commit messages than "part N". > What would be a more descriptive subject line? I wasn't really sure about the subject line since the series is for the same file - which is why I went with "part N". > What are your basing your patches on? Our CI uses drm-tip, and it's > failing to apply the patches. > I'm using drm-tip, but I can rebase and try again. Thanks. wambui. > BR, > Jani. > > > >> >> Wambui Karuga (4): >> drm/i915/display: conversion to new logging macros part 1 >> drm/i915/display: conversion to new logging macros part 2 >> drm/i915/display: conversion to new logging macros part 3 >> drm/i915/display: convert to new logging macros part 4. >> >> drivers/gpu/drm/i915/display/intel_display.c | 1021 ++++++++++-------- >> 1 file changed, 596 insertions(+), 425 deletions(-) > > -- > Jani Nikula, Intel Open Source Graphics Center >