Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1578671054-5982-1-git-send-email-martin.fuzzey@flowbird.group> <20200114152249.GA2041689@kroah.com>
In-Reply-To: <20200114152249.GA2041689@kroah.com>
From:   Todd Kjos <tkjos@google.com>
Date:   Fri, 17 Jan 2020 14:30:40 -0800
Message-ID: <CAHRSSEzi_hpPiMh3g4RzyXHjND-dhJH0W4jpg-c5jyYqhaOBSg@mail.gmail.com>
Subject: Re: [PATCH] binder: fix log spam for existing debugfs file creation.
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Martin Fuzzey <martin.fuzzey@flowbird.group>,
        =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= <arve@android.com>,
        Todd Kjos <tkjos@android.com>,
        Martijn Coenen <maco@android.com>,
        Joel Fernandes <joel@joelfernandes.org>,
        Christian Brauner <christian@brauner.io>,
        "open list:ANDROID DRIVERS" <devel@driverdev.osuosl.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jan 14, 2020 at 7:22 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Fri, Jan 10, 2020 at 04:44:01PM +0100, Martin Fuzzey wrote:
> > Since commit 43e23b6c0b01 ("debugfs: log errors when something goes wrong")
> > debugfs logs attempts to create existing files.
> >
> > However binder attempts to create multiple debugfs files with
> > the same name when a single PID has multiple contexts, this leads
> > to log spamming during an Android boot (17 such messages during
> > boot on my system).
> >
> > Fix this by checking if we already know the PID and only create
> > the debugfs entry for the first context per PID.
> >
> > Do the same thing for binderfs for symmetry.
> >
> > Signed-off-by: Martin Fuzzey <martin.fuzzey@flowbird.group>
>
> Does this need a "Fixes:" and cc: stable tag?

It would probably make sense to take it into 5.4 (spam issue was
introduced in 5.2).

Please add "Fixes:" as Greg suggests citing the commit above.
Acked-by: Todd Kjos <tkjos@google.com>

>
> And it would be good to get a review from the binder maintainer(s) to
> see if this is sane or not...
>
> thanks,
>
> greg k-h