Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <d7010f3bc07d2666e6bbde3140d51acd539cb55b.camel@perches.com>
Subject: Re: [PATCH 4/4] GPIO: creg-snps: fixed a typo
From:   Joe Perches <joe@perches.com>
To:     sachin agarwal <asachin591@gmail.com>, Eugeniy.Paltsev@synopsys.com
Cc:     linus.walleij@linaro.org, bgolaszewski@baylibre.com,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Sat, 18 Jan 2020 09:29:26 -0800
In-Reply-To: <20200118104506.68524-1-sachinagarwal@sachins-MacBook-2.local>
References: <20200118104506.68524-1-sachinagarwal@sachins-MacBook-2.local>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.34.1-2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, 2020-01-18 at 16:15 +0530, sachin agarwal wrote:
> From: Sachin agarwal <asachin591@gmail.com>
> 
> we had written "valiue" rather than "value".
[]
> diff --git a/drivers/gpio/gpio-creg-snps.c b/drivers/gpio/gpio-creg-snps.c
[]
> @@ -64,11 +64,11 @@ static int creg_gpio_validate_pg(struct device *dev, struct creg_gpio *hcg,
>  	if (layout->bit_per_gpio[i] < 1 || layout->bit_per_gpio[i] > 8)
>  		return -EINVAL;
>  
> -	/* Check that on valiue fits it's placeholder */
> +	/* Check that on value fits it's placeholder */

Might as well fix the it's/its usages too.

>  	if (GENMASK(31, layout->bit_per_gpio[i]) & layout->on[i])
>  		return -EINVAL;
> 
> -	/* Check that off valiue fits it's placeholder */
> +	/* Check that off value fits it's placeholder */
>  	if (GENMASK(31, layout->bit_per_gpio[i]) & layout->off[i])
>  		return -EINVAL;
>