Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp861665ybl; Sat, 18 Jan 2020 12:46:10 -0800 (PST) X-Google-Smtp-Source: APXvYqzcpA/M/ITVM6ROLFU7Kii4JLaSiv4Tyrn3r/55P4zdqfNWkxrSf/vk2ue9/UpdbWwbZ6Kz X-Received: by 2002:a9d:67d2:: with SMTP id c18mr10523805otn.362.1579380370311; Sat, 18 Jan 2020 12:46:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579380370; cv=none; d=google.com; s=arc-20160816; b=yIl/VGArLEHLB5w+fKQfcLQsFHGUwtTFcuOFFDq9XtuXQzK6sP6UraD5KbjJuO6ExV yqWvSWTez/E0LmC4zUEDDbnTSVS5p2dJKC/xOCf/UEtdR48KXV3QOid3JwsTrc/8UkMt Hp8I3ZnNZwuHUnZ2Ju9vUsiqOHQ2fTywwLStTfac4eV8rsAwajaCcjJBHhtkiuMzMXl0 zHKesZr9YKLRQJyVGjF7pvsINF5GKtgkUaybgawYe0br5oVNO4OCYxGEhrbw+7DIfxZE +R6uClAJsmsZsDamgFcN6l3viRQXdIAnfzrU5ow57OJg+qG2eIulE5wCJCyPNrZE9DuA ImBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=zoflbrywHown98SWqX2OQZb8P7vOFu8Bc1hY/Ui+HR0=; b=JnjRLsqh4aC/8qrv3aupXn1R919OCUN9QYR4Gy1GLhtO2wSc5v9vmrdueSVDL4xlP1 ja6RMd4PtfEt1MbCWzRPZnrSMDkFTNkwFdqUuZ5G0xdAPJghtO1APY6z+iG6CqUVBLmb ioeWMvJ0EoePywqgGdom+YtDdgODOPMrNc4HAvHKeEMMEvO++j6GRz9UlAh41/DlHCEm feFkHUVzkxqGfe7H1oB7X+HkibTkVAelkgHdHHeREjEg/d3tg/VsGoUp9JSn5C05IVH5 3bTuJpy78Ii0w37ZPsu3XXgCQeNBhflN8Bf79hcetDVKvsRKL8UiYZTHMbt8PjPbkyob XQdw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=n8AORjqh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l131si14689665oig.120.2020.01.18.12.45.57; Sat, 18 Jan 2020 12:46:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=n8AORjqh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727107AbgARUlh (ORCPT + 99 others); Sat, 18 Jan 2020 15:41:37 -0500 Received: from mail-oi1-f169.google.com ([209.85.167.169]:47040 "EHLO mail-oi1-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726933AbgARUlh (ORCPT ); Sat, 18 Jan 2020 15:41:37 -0500 Received: by mail-oi1-f169.google.com with SMTP id 13so25334370oij.13 for ; Sat, 18 Jan 2020 12:41:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zoflbrywHown98SWqX2OQZb8P7vOFu8Bc1hY/Ui+HR0=; b=n8AORjqh7ykx52tB6IqrWvYbz/n7Zlq8YOB8ciNtlGuiCjfK7FTUbfx/WV/JUE1rNg WmSCLVUxYcAFkQZRkMkt81uYhRag/Z1ojsNnOBnCPxtxLxTu6OWxPY5JDzryM+c0opv2 U0o9M4fTP3EMX9aenpWjuWq53zgOROz0FNBQvapav808gjdXruHTP89k8U+RnZhrYFKv UCPff61/k1qeD90NkPn3jg1kzuTxDwWDSX2dih3Vkd3LAK1UyLGchdUUUDzBg1kVrhg4 Jx6yTonVT0PImPuTqhe+7gOV+88Y0guJT2m7Permck58ENR3yxMNgmtOmcijAgGmG0D7 9Deg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zoflbrywHown98SWqX2OQZb8P7vOFu8Bc1hY/Ui+HR0=; b=H8APdawWFy7hIRquX51ePUDjKbp9xNiuOVZAtqS0dX3+tcHG+/dsI7575U04S25px1 5DsqS22r3Clt0viH33m+eoCvjjxEKqtyir1JzP3GuAUpuEx33mQ9ZcuySsaxVu8orTep BpRzb4/Yo9p79GhAkXXgVEdxuGivECkbn1QUCb+2fuKzarhWIGO1KGpOx23QgMjB4pDz KzFuQl8UFh5Q5lvG4hm38zw9GvK1Y716kLXFfadHRaUufT8nKDpoH5WybOxclOengJfN MVTKhNUR66qKmDNgdNJldSM273Kwi9HZgutDKwlotRDjB+m3MLJRM+1TrQBHkuAXEzSH diNQ== X-Gm-Message-State: APjAAAWjqy/b6k22KXdtNZA11Zaq5XeurPf9z7UsPOSoQpIpco0lzZzQ QnDEcl13sKkIs7SdLjZC7X9fUe0+cRlEZKx/yi8= X-Received: by 2002:aca:6545:: with SMTP id j5mr8388440oiw.60.1579380096142; Sat, 18 Jan 2020 12:41:36 -0800 (PST) MIME-Version: 1.0 References: <0000000000007523a60576e80a47@google.com> <20180928070042.GF3439@hirez.programming.kicks-ass.net> In-Reply-To: From: Cong Wang Date: Sat, 18 Jan 2020 12:41:25 -0800 Message-ID: Subject: Re: BUG: MAX_LOCKDEP_CHAINS too low! To: Taehee Yoo Cc: Dmitry Vyukov , Peter Zijlstra , syzbot , Ingo Molnar , Will Deacon , LKML , syzkaller-bugs , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 16, 2020 at 7:09 AM Taehee Yoo wrote: > Yes, I fully agree with this. > If we calculate the subclass for lock_nested() very well, I think we > might use static lockdep key for addr_list_lock_key too. I think > "dev->upper_level" and "dev->lower_level" might be used as subclass. > These values are updated recursively in master/nomaster operation. Great! I will think about this too. At least I will remove the other keys for net-next. Thanks.