Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2] io_uring: optimise sqe-to-req flags translation
To:     Pavel Begunkov <asml.silence@gmail.com>, io-uring@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <b507d39e-ec2b-5c9f-0fd0-6ab1b0491cad@kernel.dk>
 <06bcf64774c4730b33d1ef65e4fcb67f381cae08.1579340590.git.asml.silence@gmail.com>
 <b773df2f-8873-77f3-d25d-b59c66f3a04b@kernel.dk>
 <ad7c75c3-b660-9814-e3fe-ef5a3acd7e8f@gmail.com>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <b358b578-f0bd-8886-a75b-b9caefea2496@kernel.dk>
Date:   Sat, 18 Jan 2020 13:45:12 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <ad7c75c3-b660-9814-e3fe-ef5a3acd7e8f@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 1/18/20 10:10 AM, Pavel Begunkov wrote:
> On 18/01/2020 19:34, Jens Axboe wrote:
>>> +enum {
>>> +	/* correspond one-to-one to IOSQE_IO_* flags*/
>>> +	REQ_F_FIXED_FILE	= BIT(REQ_F_FIXED_FILE_BIT),	/* ctx owns file */
>>
>> I'd put the comment on top of the line instead, these lines are way too
>> long.
> 
> I find it less readable, but let's see

Well, the monster lines are unreadable on an 80-char display... I'm generally
not a stickler with 80 chars, if a few over needs we don't need to break,
I'm all for it. But the long comments are unreadable for me.

-- 
Jens Axboe