Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp862909ybl; Sat, 18 Jan 2020 12:48:28 -0800 (PST) X-Google-Smtp-Source: APXvYqzYUMmrtrDqtiaMss4PN90m7pc5yXWN2rlcLj11uDBIMtRrn/5JXUOoaZ/ARc8l0aEGoeya X-Received: by 2002:a05:6830:22ee:: with SMTP id t14mr10498732otc.236.1579380508158; Sat, 18 Jan 2020 12:48:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579380508; cv=none; d=google.com; s=arc-20160816; b=YBIYQ53d3tV014MTZlr/EtxLL/pgUS84MCiADyeKGAYawcvhSAYUb//kZo4ZdE3oFG llBq5R/6/q34uPJIqrmedU1m6tEQd7yz+lljpiheobrh/FepZO1xMnTiTgVhflfQGI2p voDAqJYcRfomXbJOyzvp54ZsmKAO12XAGtTZtSu/adSdIrGLDmrE6EN4aGbm502QRgEg /Q8AqDBmasN9xBF17ViUZtlWipCdcL+p0PKMBWO6TJpicO7iqJ2/tHTICSA9JW0KNddh YJJSa8nh5jjRSca+BTHdQ/e8SkOqTmci9czpUhkusaPjtt6En+MqKm+BMQ0vV6x/0uuY XjEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=9nGxRoRYyJbnnwOrpQGmTmHPjg5LAsfCWJ/kF5ALD1c=; b=aY0l/zcQJEMk7cVUasNWrh9TKz+ENqoqYV+c8WIw3XmhQ7ImwAkqGenjGHvC0afpVM guYQG2Thlv4CWKMUq/kdaolh4lzD64yFFDbXKxd66gFYK2D4oJUDrnSYk+Lzju0Mdpzy qwN90m0UWH3XrcNtQfRTtV8PTTtYdtPD0RQiFCA4zynlU3dbnLKlq19OfikQmHUqnKmC z6cBYDYcIPEg2SAC9+3IhMANCihgFLVxUfk/BPZ3ICJGvang+0YzeOI1TMUYIIyvOpMw 01TAUOjr+SI+k3lXNIapyO5IiuS/kfMV7Bf3ggQ22LNDRCiSl5W4bp7Cb5hh1yVhnSFX v5dw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=B2jmbkHR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p207si7531643oic.111.2020.01.18.12.48.15; Sat, 18 Jan 2020 12:48:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=B2jmbkHR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727114AbgARUqS (ORCPT + 99 others); Sat, 18 Jan 2020 15:46:18 -0500 Received: from mail-pl1-f196.google.com ([209.85.214.196]:36769 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726933AbgARUqS (ORCPT ); Sat, 18 Jan 2020 15:46:18 -0500 Received: by mail-pl1-f196.google.com with SMTP id a6so11387584plm.3 for ; Sat, 18 Jan 2020 12:46:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=9nGxRoRYyJbnnwOrpQGmTmHPjg5LAsfCWJ/kF5ALD1c=; b=B2jmbkHRX/6OAJ3J9TuDRJDwLJP9i+J0xOs/l8MaJ6yLbqPtg+H3sPVxzDvmJfsvk1 G3gjA2wSOd93b04nIHXqvTZj7lZklbDxngWulRlMu0TY2MrLURgiXzSPZDvbPL5B5kk5 nbm6SZVXnQJd5+RS9i4fDb77UKUSE0TsP/gH1IJQ8aNVfLHN6Xp3iWgAiDO/fqDhIg5p 4aoPdYv7lka7KDH9U6RclFBtLoR6DkkxGv/AqcyHgPmY4yx8xhlEop735ZtN70Gfejvb RKfuaPutAy+00ct3U2y2okMI9F+dLr9qA99rWvb4TyR/h3eNp8tu5BXl7sv1l7wWx5AI ptTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9nGxRoRYyJbnnwOrpQGmTmHPjg5LAsfCWJ/kF5ALD1c=; b=EFZSCqZvYAn4/DbLfqtBfLcve1t4QEEWCEcGYD5fY2WFOjzK0mT1+PlGpFhaL0CQxt TvtfvWaQ7oTMYiHd3XXvt2XWOZycoZVMDweOMAsHb5Ae7b0lIW+PuTZkSLCHWzuswD7Y iCLG/5XLsm49ts394lAjS4/r4pq8+gwW9/okn0mKfaB9rYZyLue7NG5PiuyQdFm7k/+E AXHOgz+rCleXZ5nx53vCAXWJlLeq5qPPuDGt3okeVlI5Ti3nirFafU1b7exzxxKirPg7 mBKMppXRI+W46k1deF8DDaka6v15+gIrZnxFHa3ybX1Ws4UhmCPpehF4UWqeEFSNYLQE kdfg== X-Gm-Message-State: APjAAAVV2gw0CssSVD1IXtjz3ycu5LaUT9Iu80+sVyTpmBk4r85TcuIq 2Z6fsLAHoYpUwPO8elRl7fANQsvmZr8= X-Received: by 2002:a17:90a:31cf:: with SMTP id j15mr14244745pjf.120.1579380377239; Sat, 18 Jan 2020 12:46:17 -0800 (PST) Received: from [192.168.1.188] ([66.219.217.145]) by smtp.gmail.com with ESMTPSA id m19sm2528305pjv.10.2020.01.18.12.46.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 18 Jan 2020 12:46:16 -0800 (PST) Subject: Re: [PATCH v3 1/1] io_uring: optimise sqe-to-req flags translation To: Pavel Begunkov , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: <648dbd08d8acb9c959acdd0fc76e8482d83635dd.1579368079.git.asml.silence@gmail.com> From: Jens Axboe Message-ID: <7197ccc8-6fe2-3405-c88d-95bcb909d55a@kernel.dk> Date: Sat, 18 Jan 2020 13:46:14 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <648dbd08d8acb9c959acdd0fc76e8482d83635dd.1579368079.git.asml.silence@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/18/20 10:22 AM, Pavel Begunkov wrote: > For each IOSQE_* flag there is a corresponding REQ_F_* flag. And there > is a repetitive pattern of their translation: > e.g. if (sqe->flags & SQE_FLAG*) req->flags |= REQ_F_FLAG* > > Use same numeric values/bits for them and copy instead of manual > handling. Thanks, applied. -- Jens Axboe