Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp863025ybl; Sat, 18 Jan 2020 12:48:40 -0800 (PST) X-Google-Smtp-Source: APXvYqzjFq9tmGU06K/h/KJI8Yo8t1yxBf0ehgY8RadOWsYq2/NqmeVpQxeCz3or19tfoPDhXHXU X-Received: by 2002:aca:3182:: with SMTP id x124mr8263773oix.170.1579380520556; Sat, 18 Jan 2020 12:48:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579380520; cv=none; d=google.com; s=arc-20160816; b=XtxaK5axEmw9plCowA3zJI2nxSsrZkFR9wL4f6QGTw2OTy0a49IvDu71S5zFMyR14b wB6N8BBtyCinCEfMVEplwZj8RBDi4HNoGT1uWfjINttjf7pIdpRKXBV5DkNY5BtFTSOA I00txg9hyuz6tDWYrIlDU4zu0FsQvIG5oqKL5A1x/GaZ3gudyHRIxSkx6FGPO0uF+td3 Dr6M521VRtzv7CxMUpcLpZyOSHBznaBfxFOIJRB+Cey0Gu03cvkMs6lheXfi3RT8aihO bQsVSyHiOXypaONwptKWIIhxoUCwY1t5PG+yNkc6C/Z5TBLKrUnAnFi9dXN8MGNsmwq0 9mxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=aBvwG5hs/viXjFOybOIYOqL0J9/NjAJR55aMcHkMqz4=; b=heCw0OxvjX6Xjtsodty7umiXMXjyCodPKLVTOsiug/u6sWL1RHmQJk4/hdzjNgnVTL GIsBBke7uIFzz71/17yzWHgWgjQoXTE3AZ+iUQJK1AhvoTUYbcd2aZ+mp5WNHajS56/q XxgoH3qUGRZUxi9q0FfiVXV0n/Wp/TKSc0Iau5ap5B6nYKhlbwt07fdLLHTtzW2S+cTc v9kFvlLZ25zAVfRLBsjf+eIK33jcHi8ccjqURn8/z0qXUuPic+vPYPGIRuZQarEbquUh HEElZgXkVjUZxGpvBj+0grCv4n+8TG6xBacVtBeb0LS81tCDvGEMXbqHoeL4ebNxaRKn Fh8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=Inb6NhQE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t12si17267492otm.224.2020.01.18.12.48.28; Sat, 18 Jan 2020 12:48:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=Inb6NhQE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727178AbgARUqk (ORCPT + 99 others); Sat, 18 Jan 2020 15:46:40 -0500 Received: from mail-pl1-f196.google.com ([209.85.214.196]:33588 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726997AbgARUqj (ORCPT ); Sat, 18 Jan 2020 15:46:39 -0500 Received: by mail-pl1-f196.google.com with SMTP id ay11so11380063plb.0 for ; Sat, 18 Jan 2020 12:46:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=aBvwG5hs/viXjFOybOIYOqL0J9/NjAJR55aMcHkMqz4=; b=Inb6NhQE6dYl3CVHDsOi2zXEBpNBU5RUcTsbaziD/JicVz7jAIJPYErWhulW0IFZp3 cHAFAsTbSpWgpbFJmrSjM42Td8TOgCcYdYy14I3nGBDv1Qif2VoKS/CB+acWtavKJ7SA yL+4Zfo3ukT6yP30COGuuI27F4hb7jGd5IAngkeHzL2N+n5XFOsCnTwe0wpZGtlBFM2E Phwb0Q1CACMW+jKyz+hU1TlshN1a0cPwtEWQ8Jg1LpHoztXMOfGoktO0Eqj3YJu1U8Wv 7ObOXnYx0Q/fkRYmp7zdzu5D138+Tm0KDmQUxW55+WlEc2qeUHRMeeycc5FWTatrrW+g xKeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aBvwG5hs/viXjFOybOIYOqL0J9/NjAJR55aMcHkMqz4=; b=TGlgqCXFjlqBf6ZmTuIIKt3cNmMWohjC44VjTPK/Jl5gKnqSoIpMMhJmhu76TUqA/2 9Ew3At9ycAk/rJXpc2W29TcsKQVLjq/CZRfW8bPWCBpv0pqq8eTKLD7AJ+hmAS1Qgoyg vYPgHyGhLz72AefsxdWHoLmlCU+s65ljEKlXPprqmi63GEXOA8f2y51i/UiIB8PrAQKO plrmiBWtZp2nkByCbINrWD6S1nEnqIBP5wJqdVGtMfUnaLmIHeqXPNAb48/4pXrp+po6 uzIlD5D8hYuagjum2jbC0xCO5W9gQJSS/Ck/gXibnQFh0ykD+9NCtJ8cV/L/3N6Y8Ckj u7GQ== X-Gm-Message-State: APjAAAUF2bTGqjdjPxTZ1Syr0yNCKst+OB6basgR9zzFNYBF0k171A+l PG/wF6ZvEKcKrYjIvi3fx96zvaZXdMg= X-Received: by 2002:a17:90a:2351:: with SMTP id f75mr14131461pje.133.1579380399007; Sat, 18 Jan 2020 12:46:39 -0800 (PST) Received: from [192.168.1.188] ([66.219.217.145]) by smtp.gmail.com with ESMTPSA id o7sm35806945pfg.138.2020.01.18.12.46.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 18 Jan 2020 12:46:38 -0800 (PST) Subject: Re: [PATCH] io_uring: use labeled array init in io_op_defs To: Pavel Begunkov , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: From: Jens Axboe Message-ID: <8eadfa1b-5dee-a6b4-e217-81fdd2484218@kernel.dk> Date: Sat, 18 Jan 2020 13:46:36 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/18/20 11:35 AM, Pavel Begunkov wrote: > Don't rely on implicit ordering of IORING_OP_ and explicitly place them > at a right place in io_op_defs. Now former comments are now a part of > the code and won't ever outdate. Looks good to me, thanks. Applied. -- Jens Axboe