Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 18 Jan 2020 16:15:28 -0800
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Michal =?ISO-8859-1?Q?Koutn=FD?= <mkoutny@suse.com>
Cc:     Michal Hocko <mhocko@kernel.org>,
        Christopher Lameter <cl@linux.com>,
        LKML <linux-kernel@vger.kernel.org>, linux-mm@kvack.org
Subject: Re: SLUB: purpose of sysfs events on cache creation/removal
Message-Id: <20200118161528.94dc18c074aeaa384200486b@linux-foundation.org>
In-Reply-To: <20200117171331.GA17179@blackbody.suse.cz>
References: <20191127174317.GD26807@dhcp22.suse.cz>
        <20191204132812.GF25242@dhcp22.suse.cz>
        <alpine.DEB.2.21.1912041524290.18825@www.lameter.com>
        <20191204153225.GM25242@dhcp22.suse.cz>
        <alpine.DEB.2.21.1912041652410.29709@www.lameter.com>
        <20191204173224.GN25242@dhcp22.suse.cz>
        <20200106115733.GH12699@dhcp22.suse.cz>
        <alpine.DEB.2.21.2001061550270.23163@www.lameter.com>
        <20200109145236.GS4951@dhcp22.suse.cz>
        <20200109114415.cf01bd3ad30c5c4aec981653@linux-foundation.org>
        <20200117171331.GA17179@blackbody.suse.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 17 Jan 2020 18:13:31 +0100 Michal Koutn=FD <mkoutny@suse.com> wrote:

> Hello.
>=20
> On Thu, Jan 09, 2020 at 11:44:15AM -0800, Andrew Morton <akpm@linux-found=
ation.org> wrote:
> > I looked at it - there wasn't really any compelling followup.
> FTR, I noticed udevd consuming non-negligible CPU cycles when doing some
> cgroup stress testing. And even extrapolating to less artificial
> situations, the udev events seem to cause useless tickling of udevd.
>=20
> I used the simple script below
> cat measure.sh <<EOD
> sample() {
>         local n=3D$(echo|awk "END {print int(40/$1)}")
>=20
>         for i in $(seq $n) ; do
>                 mkdir /sys/fs/cgroup/memory/grp1 ;
>                 echo 0 >/sys/fs/cgroup/memory/grp1/cgroup.procs ;
>                 /usr/bin/sleep $1 ;
>                 echo 0 >/sys/fs/cgroup/memory/cgroup.procs ;
>                 rmdir /sys/fs/cgroup/memory/grp1 ;
>         done
> }
>=20
> for d in 0.004 0.008 0.016 0.032 0.064 0.128 0.256 0.5 1 ; do
>         echo 0 >/sys/fs/cgroup/cpuacct/system.slice/systemd-udevd.service=
/cpuacct.usage
>         time sample $d 2>&1 | grep real
>         echo -n "udev "
>         cat /sys/fs/cgroup/cpuacct/system.slice/systemd-udevd.service/cpu=
acct.usage
> done
> EOD
>=20
> and I drew the following ballpark conclusion:
> 1.7% CPU time at 1 event/s -> 60 event/s 100% cpu
>=20
> (The event is one mkdir/migrate/rmdir sequence. Numbers are from dummy
> test VM, so take with a grain of salt.)

Thanks.  What effect does this patch have upon these numbers?

>=20
> > If this change should be pursued then can we please have a formal
> > resend?
> Who's supposed to do that?

Typically the author, but not always.  If someone else is particularly
motivated to get a patch merged up they can take it over.