Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 18 Jan 2020 17:04:45 -0800
From:   Andrew Morton <akpm@linux-foundation.org>
To:     David Rientjes <rientjes@google.com>
Cc:     Vlastimil Babka <vbabka@suse.cz>,
        Mel Gorman <mgorman@techsingularity.net>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch v2] mm, thp: fix defrag setting if newline is not used
Message-Id: <20200118170445.370d908ce29f42068390addb@linux-foundation.org>
In-Reply-To: <alpine.DEB.2.21.2001171411020.56385@chino.kir.corp.google.com>
References: <alpine.DEB.2.21.2001141757490.108121@chino.kir.corp.google.com>
        <20200116191609.3972fd5301cf364a27381923@linux-foundation.org>
        <025511aa-4721-2edb-d658-78d6368a9101@suse.cz>
        <alpine.DEB.2.21.2001170136280.20618@chino.kir.corp.google.com>
        <a3c269a7-ff41-ee7c-9041-ee06e50c5a10@suse.cz>
        <alpine.DEB.2.21.2001171411020.56385@chino.kir.corp.google.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 17 Jan 2020 14:11:48 -0800 (PST) David Rientjes <rientjes@google.com> wrote:

> If thp defrag setting "defer" is used and a newline is *not* used when
> writing to the sysfs file, this is interpreted as the "defer+madvise"
> option.
> 
> This is because we do prefix matching and if five characters are written
> without a newline, the current code ends up comparing to the first five
> bytes of the "defer+madvise" option and using that instead.
> 
> Use the more appropriate sysfs_streq() that handles the trailing newline
> for us.  Since this doubles as a nice cleanup, do it in enabled_store()
> as well.

I can't really I really understand this prefix-matching thing that
we're taking away.  Documentation/admin-guide/mm/transhuge.rst doesn't
appear to mention it.  Could we please add a paragraph to the changelog
to spell all this out.  Bonus points for formally describing the
behaviour which we're removing!

Thanks.