Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1114645ybl; Sat, 18 Jan 2020 19:08:27 -0800 (PST) X-Google-Smtp-Source: APXvYqz4wYv+dRdvKtJ3kqEXqLGOL7tinAkfyI/1rl7EyN2e8z0P77RjNqOTaVzZ6uZd5rSokY+4 X-Received: by 2002:a05:6808:64d:: with SMTP id z13mr8981159oih.104.1579403307877; Sat, 18 Jan 2020 19:08:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579403307; cv=none; d=google.com; s=arc-20160816; b=Wg8CScf3OAEEaqShowWw0M6y9Iw6iocYhRh0iYNQ8mHltxQ32dswrA99yInemMiwF9 Y3LxiurYnltgZ2SUuj2gdag30w7UocytPwKP5/TZAosZHw7XNpff1ze56m4m5lCQGmgs BwNBqdxbjCh80DBr7t6IoLd8AT1UN1xcgowZWsqW08juVXGjrwpCRPW6UOBL2i9ry8zv eauQ4VTln+1dnE4uCb/HHLr/k663XYdAU5PbP+1OXW3gR2Iik6xoN39BfOgkPpRru08z 0VTOa7VBiTbOhNUjpbfc/Op5sxO+JAaaakaXsKatTFHAZ67IkgIXU2dV7Q/LOhzyuhl8 F1nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=VF72t0KuPBRiUUZz8Xsnb6bB4YbY8zTvdEualhJ6inY=; b=TcAwFtZh1DW34uEsrKXTrfOcPDPbECJbkRv4fbzrPVfiwl4rFQMu0svEeoVhZiTdIA 7GQiEpoyN8THeUBDhrhX2X+2ytVegb6WJlO5NDg+8zVjqx4MOQTm5nHopRHauHgndIq9 B11hdBxgCBJOB/jxBMvAE0K0sS3cGSTpledDUkW7nSbhYzZnVGYtRDRB9Yu3BjogPe08 fb/MVrhHQZup760pR0Iu3vSfdIlUCq8WG4NPRMJdrC9XBrXBd7C33pTP3MjXugTef9RL Ywy3G4yTw1Z3zM2cTTS/p8ooe034o5dSkAQW1TXDL/qRmTzQpOe8R0IlmEj2mPyJNgGR Qo9A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e73si16131836oib.145.2020.01.18.19.08.16; Sat, 18 Jan 2020 19:08:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728709AbgASDHT (ORCPT + 99 others); Sat, 18 Jan 2020 22:07:19 -0500 Received: from mga07.intel.com ([134.134.136.100]:14153 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727403AbgASDHT (ORCPT ); Sat, 18 Jan 2020 22:07:19 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jan 2020 19:07:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,336,1574150400"; d="scan'208";a="258308765" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by fmsmga002.fm.intel.com with ESMTP; 18 Jan 2020 19:07:16 -0800 From: Wei Yang To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, mhocko@suse.com, yang.shi@linux.alibaba.com, Wei Yang Subject: [PATCH 0/8] mm/migrate.c: cleanup on do_pages_move() Date: Sun, 19 Jan 2020 11:06:28 +0800 Message-Id: <20200119030636.11899-1-richardw.yang@linux.intel.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The logic in do_pages_move() is a little mess for audience to read and has some potential error on handling the return value. Especially there are three calls on do_move_pages_to_node() and store_status() with almost the same form. This patch set tries to make the code a little friendly for audience by consolidate the calls and remove some unnecessary repeat code. After this, we can do a better fix. Wei Yang (8): mm/migrate.c: skip node check if done in last round mm/migrate.c: not necessary to check start and i mm/migrate.c: reform the last call on do_move_pages_to_node() mm/migrate.c: wrap do_move_pages_to_node() and store_status() mm/migrate.c: check pagelist in move_pages_and_store_status() mm/migrate.c: handle same node and add failure in the same way mm/migrate.c: move page on next iteration mm/migrate.c: use break instead of goto out_flush mm/migrate.c | 90 ++++++++++++++++++++++++++++------------------------ 1 file changed, 48 insertions(+), 42 deletions(-) -- 2.17.1