Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1114699ybl; Sat, 18 Jan 2020 19:08:32 -0800 (PST) X-Google-Smtp-Source: APXvYqxK5N70M/qKrgcN7iQZhVUOMLoOjGx/pVLLo7bkA5EOvQgtXqKjzFu8M3qdQvQJCm2ACZoG X-Received: by 2002:a05:6830:1e16:: with SMTP id s22mr11631570otr.340.1579403312536; Sat, 18 Jan 2020 19:08:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579403312; cv=none; d=google.com; s=arc-20160816; b=J6uGO9it3WvbFwJ5sM75zlcxBtchAE66JbpGRgkJTJ2LFHGSYsdxmjpfS47aq58NNN lejXfgeV+7JT8eNfjH/A3Rmi1zP4F8xRUtEa3HHwnErz6lqe65tefsGqhEb3P2TGc1k6 RbYl6GiH/sZIQ/pwnaizTd4y/y8+8/hPoS2dkkSL/t4Wi7snn3N/2Fz13KcG2ky/xigu 53c3zUh+4jACOD5neG0c3oK2pr/QRWujLDYxGflQ52z+9yI6+c6rf2L/cnVWt+0Ybe9z 0BBOtQAJEFntmL7H7wjalWb4qtBBQBYzrNINwTp/HYjBX7z2xvOCvpnS8leEJ8dGuTjY ttsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=IT2ylIMjj6sBCBAzqo0eZeI7+yaF5dwgASvoBCCoSas=; b=iBBVrbDvv2JBe4CTHdQ5aj4HVFvPe0RybmAxxIne3+5WKzIAK+6jsDYSF5AfQvN3Ny vlhKmXvKLkffojTGx5FmPlapE0VewIMSKOUuzzBSWhwEVm6iLMbCJpZj74/AxslR7Cyg lJ67XLEqDRmwsAKFYLwI6k2vPlPZBMlGmseBY+9j9LKNl7MOWl9Cw8HiqQt+EKqGKnWa RY0fFQ7ZBkmu6Vmu3iM+xWoTYZC2l3LlpnMaDAHzeLWO4WpS/lNVstW71rz+CYKBRgJ6 lMq2t7YnWn9ma8ZyaSFjB9scUUVhH7P+oyLtus61NInbpIi8zT1S0WkSX3TsWdA8jz37 nrAQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c21si18623965oto.176.2020.01.18.19.08.20; Sat, 18 Jan 2020 19:08:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729015AbgASDHZ (ORCPT + 99 others); Sat, 18 Jan 2020 22:07:25 -0500 Received: from mga07.intel.com ([134.134.136.100]:14153 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727403AbgASDHX (ORCPT ); Sat, 18 Jan 2020 22:07:23 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jan 2020 19:07:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,336,1574150400"; d="scan'208";a="258308778" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by fmsmga002.fm.intel.com with ESMTP; 18 Jan 2020 19:07:22 -0800 From: Wei Yang To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, mhocko@suse.com, yang.shi@linux.alibaba.com, Wei Yang Subject: [PATCH 3/8] mm/migrate.c: reform the last call on do_move_pages_to_node() Date: Sun, 19 Jan 2020 11:06:31 +0800 Message-Id: <20200119030636.11899-4-richardw.yang@linux.intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200119030636.11899-1-richardw.yang@linux.intel.com> References: <20200119030636.11899-1-richardw.yang@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org No functional change, just reform it to make it as the same shape as other calls on do_move_pages_to_node(). This is a preparation for further cleanup. Signed-off-by: Wei Yang --- mm/migrate.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/mm/migrate.c b/mm/migrate.c index c3ef70de5876..4a63fb8fbb6d 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -1675,8 +1675,12 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes, /* Make sure we do not overwrite the existing error */ err1 = do_move_pages_to_node(mm, &pagelist, current_node); - if (!err1) - err1 = store_status(status, start, current_node, i - start); + if (err1) { + if (err >= 0) + err = err1; + goto out; + } + err1 = store_status(status, start, current_node, i - start); if (err >= 0) err = err1; out: -- 2.17.1