Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] mm: move_pages: fix the return value if there are
 not-migrated pages
To:     Wei Yang <richardw.yang@linux.intel.com>
Cc:     mhocko@suse.com, akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org
References: <1579325203-16405-1-git-send-email-yang.shi@linux.alibaba.com>
 <20200119023720.GD9745@richard>
From:   Yang Shi <yang.shi@linux.alibaba.com>
Message-ID: <6b4bda26-10c1-3631-3b49-293935975bae@linux.alibaba.com>
Date:   Sat, 18 Jan 2020 21:44:15 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)
 Gecko/20100101 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <20200119023720.GD9745@richard>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 1/18/20 6:37 PM, Wei Yang wrote:
> On Sat, Jan 18, 2020 at 01:26:43PM +0800, Yang Shi wrote:
>> The do_move_pages_to_node() might return > 0 value, the number of pages
>> that are not migrated, then the value will be returned to userspace
>> directly.  But, move_pages() syscall would just return 0 or errno.  So,
>> we need reset the return value to 0 for such case as what pre-v4.17 did.
>>
>> Fixes: a49bd4d71637 ("mm, numa: rework do_pages_move")
>> Cc: Michal Hocko <mhocko@suse.com>
>> Cc: Wei Yang <richardw.yang@linux.intel.com>
>> Cc: <stable@vger.kernel.org>    [4.17+]
>> Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
>> ---
>> mm/migrate.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/mm/migrate.c b/mm/migrate.c
>> index 86873b6..3e75432 100644
>> --- a/mm/migrate.c
>> +++ b/mm/migrate.c
>> @@ -1659,8 +1659,11 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes,
>> 			goto out_flush;
>>
>> 		err = do_move_pages_to_node(mm, &pagelist, current_node);
>> -		if (err)
>> +		if (err) {
>> +			if (err > 0)
>> +				err = 0;
>> 			goto out;
>> +		}
>> 		if (i > start) {
>> 			err = store_status(status, start, current_node, i - start);
>> 			if (err)
>> -- 
>> 1.8.3.1
>
> Hey, I am afraid you missed something. There are three calls of
> do_move_pages_to_node() in do_pages_move(). Why you just handle one return
> value? How about the other two?

A late night patch... I just simply missed those two. Thanks for 
catching it, will resolve in v2.

>