Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 19 Jan 2020 21:52:33 +0100
From:   Pali =?utf-8?B?Um9ow6Fy?= <pali.rohar@gmail.com>
To:     Namjae Jeon <linkinjeon@gmail.com>
Cc:     linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        gregkh@linuxfoundation.org, valdis.kletnieks@vt.edu, hch@lst.de,
        sj1557.seo@samsung.com, arnd@arndb.de, namjae.jeon@samsung.com
Subject: Re: [PATCH v11 02/14] exfat: add super block operations
Message-ID: <20200119205233.g2kliii2ywilt6tb@pali>
References: <20200118150348.9972-1-linkinjeon@gmail.com>
 <20200118150348.9972-3-linkinjeon@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="7jgbxc5qn73t55m6"
Content-Disposition: inline
In-Reply-To: <20200118150348.9972-3-linkinjeon@gmail.com>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--7jgbxc5qn73t55m6
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sunday 19 January 2020 00:03:36 Namjae Jeon wrote:
> +	case Opt_time_offset:
> +		/*
> +		 * GMT+-12 zones may have DST corrections so at least
> +		 * 13 hours difference is needed. Make the limit 24
> +		 * just in case someone invents something unusual.
> +		 */
> +		if (result.int_32 < -24 * 60 || result.int_32 > 24 * 60)
> +			return -EINVAL;
> +		opts->time_offset =3D result.int_32;
> +		break;

"13 hours difference is needed"

This is not truth :-) Every traveller knows that Kiribati has only
standard time and is in GMT+14 time zone.

But limit =C2=B124 is enough, at least for now.

--=20
Pali Roh=C3=A1r
pali.rohar@gmail.com

--7jgbxc5qn73t55m6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EARECAB0WIQS4VrIQdKium2krgIWL8Mk9A+RDUgUCXiTBjwAKCRCL8Mk9A+RD
UkMuAJ9+XdZ3fap1ybZvyxYXQeQUKLTmeQCfezGKM287Fca2NNfPMGGLMJUD2CE=
=H+vh
-----END PGP SIGNATURE-----

--7jgbxc5qn73t55m6--