Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1906037ybl; Sun, 19 Jan 2020 14:09:16 -0800 (PST) X-Google-Smtp-Source: APXvYqz3IcrgDMbkiarTPHBAcAIITfl0m9cdkbtzOQVSqTKNJLByhiK/JU34cuY37azgQeHFYov3 X-Received: by 2002:aca:4a08:: with SMTP id x8mr11020915oia.39.1579471756678; Sun, 19 Jan 2020 14:09:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579471756; cv=none; d=google.com; s=arc-20160816; b=R+//1tlL4ptIG5IofY3AkXmceXfYXIDBcT1yBdk2ILXY7S7VCz08DmVpBhKnmAvcUQ g09xVGagzdKBMofK/ffu4hffHf4Eg0v/o0YpPUo2LCLayGk0ob8XXfs+C2wRteW3ajzD j49eeByIdF/RUjxKSCgKe8KLjCm9XojrQA49/Q9OroXUT/Y1RbTxS0vUEGwsh08XDOMo 4hyIYZYJhVq65sWnLryz2LtSpE1dLmrZlfyi4WYQo0j1oYLADPoD10g1q1OqN5XUiru9 pYECRA2ScI4Np2r+TtTS0+ANyRRVokJstMeU+atYOha01Gd6M1IvSVBdvoLf/XwOcLNe p3ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date:dkim-signature; bh=BYSZ9xL7TDf1GtsTEJ0J+4ZhcMv2ysvRekB03PSrVjA=; b=h8UUO/tTav2qWfNXT4P9zwovP9h01zXLEqyISALNwIngM7YRgtBmSJsZbnYMCeQk5d Xfvup4TuYHm+PW/jfd/h8aHJw+oyYTKIdkwL8WGfJY5vr53NORlSf8xYHFlK/weOigaD jOqeD+38fq8kkL9wZpwUbuMV4k5r2c+J+LeJ5XowIyXQoePQdd0lWD49LMNXUqkPnR7M nUC+RCDYydkDA+p1rw5XRLb/XBQd1ONcHDV8HpYVFT7uy5BVcZBq8kk7Xd5AhswiB7wE WAlkN9sCRF6ftoL6K9jWj7naCFugbK3d6vaig8GJmTS0b9sIb3KaU8ciYcBpAB5HySJq OgUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=KiX394NO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f60si19233057otf.119.2020.01.19.14.09.04; Sun, 19 Jan 2020 14:09:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=KiX394NO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728853AbgASWHG (ORCPT + 99 others); Sun, 19 Jan 2020 17:07:06 -0500 Received: from mail-pj1-f68.google.com ([209.85.216.68]:54373 "EHLO mail-pj1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727195AbgASWHG (ORCPT ); Sun, 19 Jan 2020 17:07:06 -0500 Received: by mail-pj1-f68.google.com with SMTP id kx11so5791211pjb.4 for ; Sun, 19 Jan 2020 14:07:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=BYSZ9xL7TDf1GtsTEJ0J+4ZhcMv2ysvRekB03PSrVjA=; b=KiX394NOsv6PYmkqMGRP8Iik46YtKfb8doeMTrf/BVT3oFFOM4u8bJk1e3ELke+0rD fgK1nYDu3Cj6IoItqC7F24ChzoDAFnDFljOqnkAPbkrJrw1BBqbFN4TgHj4FmWJCshbY M9GxKmwx1zC8UM/HTEquW9iK4qTruYsm5kF8lu2HvORL/BsGNA9H2NV+YpBY0NSVTiqj 1/+na3yFhuUGb6l6r9qPy15UrVanBVKXjgWgCHMhrz2VcWu515skvqhNqgTVR0Qfziqs gC0lSmlFBMNV6wimpG4vdNQG64zDDnWfVNHwf+kWO/gNgGBaYWesb+t81G5ih8EkNvDk xLJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=BYSZ9xL7TDf1GtsTEJ0J+4ZhcMv2ysvRekB03PSrVjA=; b=q2PefOmJX3ld5ERCexvmtBBkU74vS9NO+PHDLRT0DJqHrwmFv5ACouDqlB1ajYEHyy HR/DKpoEi1y8liOvx9y/LEEz2HjfRIa+mO44YMC058BJ2MrbYz2c/HFqplYAz1DqNE1t uFygxe/1+oCqe5s55b+9X7ztJvBsDO3D6b9zBljd3iP0UGMMNx8C/jJdYDnCNnG224aF 2GQ3gJjkxkrfgxRZh9ki0JzgdGBvW9ucwfhnhOHy1j/0DUdVsGyjfsv38cDT/eFP1gRg 2D3pEjRP3M1w2UWYd2A9WYgbvMZFp10je8LfA+/jSP7SP0JCXh0oBOlpGq80PimhllKx px/Q== X-Gm-Message-State: APjAAAVEGu2zg8EvW1IloHoLFFbiMbfhNeEcRCXUdlpOzP+i4W3723Fv RK6mxFeZJ39OR9Mtij2J4WV3HtIiAkY= X-Received: by 2002:a17:90a:246d:: with SMTP id h100mr19167208pje.127.1579471625391; Sun, 19 Jan 2020 14:07:05 -0800 (PST) Received: from [2620:15c:17:3:3a5:23a7:5e32:4598] ([2620:15c:17:3:3a5:23a7:5e32:4598]) by smtp.gmail.com with ESMTPSA id z22sm37095796pfr.83.2020.01.19.14.07.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jan 2020 14:07:04 -0800 (PST) Date: Sun, 19 Jan 2020 14:07:04 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Wei Yang cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] mm/page_alloc.c: rename free_pages_check_bad() to check_free_page_bad() In-Reply-To: <20200119131408.23247-3-richardw.yang@linux.intel.com> Message-ID: References: <20200119131408.23247-1-richardw.yang@linux.intel.com> <20200119131408.23247-3-richardw.yang@linux.intel.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 19 Jan 2020, Wei Yang wrote: > free_pages_check_bad() is the counterpart of check_new_page_bad(), while > their naming convention is a little different. > > Use verb at first and singular form. > I think if you agree with the suggestion in patch 1/4 to fix the issue with bad page reporting that it would likely be better to fold patches 2 and 3 into that change.