Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1906472ybl; Sun, 19 Jan 2020 14:09:55 -0800 (PST) X-Google-Smtp-Source: APXvYqxg2r+9xiDOJkNw7x1ngeNorlo4UwI4+7qkufT5VY8lBijHIl0ypsDUdvmyHlpflDZapxQ7 X-Received: by 2002:a9d:2c68:: with SMTP id f95mr14043424otb.33.1579471795644; Sun, 19 Jan 2020 14:09:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579471795; cv=none; d=google.com; s=arc-20160816; b=mN2XmNb5gcszDhmP603h2JJc2CFWU3uq2UJr+dDY/xasnOu6pi8OXNhdOiW+mkhTvf j3U6RQq/OK1zfrC58r1lzaf74zOFUwiEjMuW8+JmkI/Leeh8xZSetR+o5u+huv6lBHi5 eXkzTJMM1Txyp8jq/yTznr2X/PFAgEMrk+9W5GI1KkTnSGxExsBJuxVyKyCGdUqkwSCk Dxukv5U35N/Gj9iGYjpPSsIou0c2Wip0QrQt1pCyFX03q4fKvZyiV2OLw8Mnr2MAqxOa PHGDpIz6qHtXnd6rw1+Ui7pOa62Aj3dFrZOYoh50MS0rrfefLaoI8EAnovi+Ce2wqGWx osUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date:dkim-signature; bh=/hL29TjD11NGp8Ljf9rHQ0/AomEN8AOZ3o3x8TsgXFk=; b=EqoWGmqRXJLGd5JekrUdTMzE4z8x/7suPDq7znwqMOAuB9EaychJFFva9I4aPEMQ5t F3hINyIs9R5FESCkMQPM/SqiLXMG0kiJmfjZoZrkgTF3pGxLZ8PS8CE6/XcTe1kY8LTr 7qINtfhPcWVKMyGEW6JsMmS57w/JO+7+YxEg2jBpjfkx8KQOn0oGKe4WFitEySM5MBxJ T7gfNxlVFi3NHMlmx1ZpgAZlZk6G1ZvDyNFwqWT4w41T2KXO/cjLn48QR0HIW0owxb05 IeqVZ2jPaB9Y7yCWqHYqD6a5EdPXGr4Ooi5R2W2V+pK0VVBt+zGSwKYC4f/CfJUZbYQS wmBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=Htb8a7DQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k19si16740484otb.118.2020.01.19.14.09.44; Sun, 19 Jan 2020 14:09:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=Htb8a7DQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728898AbgASWHu (ORCPT + 99 others); Sun, 19 Jan 2020 17:07:50 -0500 Received: from mail-pl1-f196.google.com ([209.85.214.196]:34290 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727195AbgASWHu (ORCPT ); Sun, 19 Jan 2020 17:07:50 -0500 Received: by mail-pl1-f196.google.com with SMTP id c9so7008210plo.1 for ; Sun, 19 Jan 2020 14:07:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=/hL29TjD11NGp8Ljf9rHQ0/AomEN8AOZ3o3x8TsgXFk=; b=Htb8a7DQKkL06WtZXoCSnCOkhCYVkwPXtAjHrfTT4Xf/VJ7nmB6lqnfWKNBWwhtOS3 siqlOUsxdP8pNvX68Wd1JyIArmQdGVKeeaqGXGHBnTRBjNnc8aCDLm1rl9WvpmeKx/Pj QopS5fa0Wg1ErVLFS6THufGI7FsHFbapGRaFomm+XycZKqMzdZm/OJuBOnyPp7Wf0nQE En/g4tVfelYvlC+Y8w9P9YCoe/9zOAkU3xct1fPfoQwy8JP0pUXHmioI7m94tgNchdEt /qaA/zvDDagxoYQ7uAx2SQtsfeG6IOBrkr4O7YrZwCKAhnagumI5u15CBCCBeV2Si05a DNOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=/hL29TjD11NGp8Ljf9rHQ0/AomEN8AOZ3o3x8TsgXFk=; b=kybcLyEJGPOiOn9C7jvvjgH5u25i4d63Ykr2XYp3Y0gjty415tCzp1gJ9QRwPS0Y6w fx0/mqMQ4vJb6HbxaxoCmyYfJSD2Ve2TrH3MsPJcT4udq0aFJ+P0Y9PT5jzum4pQ9760 B9uC/vjQ5rizhfzlV4yZxP6hobljfWxnY0k/YrQnuwlvsYCd4B2B1q2AGZXgDln87OGo lJQj6tyTwTibla9iT7T3BKv/L/ixWE3F/NCoeyhKdXdrlZvNZglfUDDmCKIgbRsFt+SU 6CJC9/Z7dFNmuudQlHgGa2SOlRtZ67uncUG+3cwEeg9hN+IDje4/kfBmMWw9yZn3WkjP DFaQ== X-Gm-Message-State: APjAAAWMaWUIMPbxGGydJEk5r91zTi207u7UgFJXrvL9HMQDMUzKwN/Y bj4bSCPFvv7Fn0F1W3PxbqOISSvgDqk= X-Received: by 2002:a17:90a:cf07:: with SMTP id h7mr19741769pju.66.1579471669229; Sun, 19 Jan 2020 14:07:49 -0800 (PST) Received: from [2620:15c:17:3:3a5:23a7:5e32:4598] ([2620:15c:17:3:3a5:23a7:5e32:4598]) by smtp.gmail.com with ESMTPSA id p17sm35685755pfn.31.2020.01.19.14.07.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jan 2020 14:07:48 -0800 (PST) Date: Sun, 19 Jan 2020 14:07:48 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Wei Yang cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] mm/page_alloc.c: bad_[reason|flags] is not necessary when PageHWPoison In-Reply-To: <20200119131408.23247-5-richardw.yang@linux.intel.com> Message-ID: References: <20200119131408.23247-1-richardw.yang@linux.intel.com> <20200119131408.23247-5-richardw.yang@linux.intel.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 19 Jan 2020, Wei Yang wrote: > Since function returns directly, bad_[reason|flags] is not used any > where. > > This is a following cleanup for commit e570f56cccd21 ("mm: > check_new_page_bad() directly returns in __PG_HWPOISON case") > > Signed-off-by: Wei Yang Acked-by: David Rientjes