Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Reply-To: Gavin Shan <gshan@redhat.com>
Subject: Re: [PATCH] KVM: arm/arm64: vgic: Drop the
 kvm_vgic_register_mmio_region()
To:     Zenghui Yu <yuzenghui@huawei.com>, maz@kernel.org
Cc:     Haibin Wang <wanghaibin.wang@huawei.com>,
        kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
References: <20200119090604.398-1-yuzenghui@huawei.com>
From:   Gavin Shan <gshan@redhat.com>
Message-ID: <479f2e5f-80c4-37e1-8f3a-2f1197fddd51@redhat.com>
Date:   Mon, 20 Jan 2020 09:47:57 +1100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.0
MIME-Version: 1.0
In-Reply-To: <20200119090604.398-1-yuzenghui@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 1/19/20 8:06 PM, Zenghui Yu wrote:
> kvm_vgic_register_mmio_region() was introduced in commit 4493b1c4866a
> ("KVM: arm/arm64: vgic-new: Add MMIO handling framework") but never
> used, and even never implemented. Remove it to avoid confusing readers.
> 
> Reported-by: Haibin Wang <wanghaibin.wang@huawei.com>
> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
> ---

Reviewed-by: Gavin Shan <gshan@redhat.com>

>   virt/kvm/arm/vgic/vgic-mmio.h | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/virt/kvm/arm/vgic/vgic-mmio.h b/virt/kvm/arm/vgic/vgic-mmio.h
> index 836f418f1ee8..5af2aefad435 100644
> --- a/virt/kvm/arm/vgic/vgic-mmio.h
> +++ b/virt/kvm/arm/vgic/vgic-mmio.h
> @@ -98,11 +98,6 @@ extern struct kvm_io_device_ops kvm_io_gic_ops;
>   		.uaccess_write = uwr,					\
>   	}
>   
> -int kvm_vgic_register_mmio_region(struct kvm *kvm, struct kvm_vcpu *vcpu,
> -				  struct vgic_register_region *reg_desc,
> -				  struct vgic_io_device *region,
> -				  int nr_irqs, bool offset_private);
> -
>   unsigned long vgic_data_mmio_bus_to_host(const void *val, unsigned int len);
>   
>   void vgic_data_host_to_mmio_bus(void *buf, unsigned int len,
>