Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 20 Jan 2020 08:36:28 +0800
From:   Wei Yang <richardw.yang@linux.intel.com>
To:     David Rientjes <rientjes@google.com>
Cc:     Wei Yang <richardw.yang@linux.intel.com>,
        akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] mm/page_alloc.c: rename free_pages_check_bad() to
 check_free_page_bad()
Message-ID: <20200120003628.GC26292@richard>
Reply-To: Wei Yang <richardw.yang@linux.intel.com>
References: <20200119131408.23247-1-richardw.yang@linux.intel.com>
 <20200119131408.23247-3-richardw.yang@linux.intel.com>
 <alpine.DEB.2.21.2001191406270.43388@chino.kir.corp.google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.21.2001191406270.43388@chino.kir.corp.google.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Jan 19, 2020 at 02:07:04PM -0800, David Rientjes wrote:
>On Sun, 19 Jan 2020, Wei Yang wrote:
>
>> free_pages_check_bad() is the counterpart of check_new_page_bad(), while
>> their naming convention is a little different.
>> 
>> Use verb at first and singular form.
>> 
>
>I think if you agree with the suggestion in patch 1/4 to fix the issue 
>with bad page reporting that it would likely be better to fold patches 2 
>and 3 into that change.

I am ok with this, while would it be confusing for review?

-- 
Wei Yang
Help you, Help me