Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200120032639.2963-1-xiaofeng.yan2012@gmail.com>
In-Reply-To: <20200120032639.2963-1-xiaofeng.yan2012@gmail.com>
From:   Taehee Yoo <ap420073@gmail.com>
Date:   Mon, 20 Jan 2020 13:44:56 +0900
Message-ID: <CAMArcTW6YXKjDnxq4bgqQM6aL=ZZ2u+SNVs+NXoA-HSLxaq16g@mail.gmail.com>
Subject: Re: [PATCH] hsr: Fix a compilation error
To:     "xiaofeng.yan" <xiaofeng.yan2012@gmail.com>
Cc:     arvid.brodin@alten.se, David Miller <davem@davemloft.net>,
        Netdev <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, yanxiaofeng7@jd.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 20 Jan 2020 at 12:26, xiaofeng.yan <xiaofeng.yan2012@gmail.com> wrote:
>
> From: "xiaofeng.yan" <yanxiaofeng7@jd.com>
>

Hi Xiaofeng,

> A compliation error happen when building branch 5.5-rc7
>
> In file included from net/hsr/hsr_main.c:12:0:
> net/hsr/hsr_main.h:194:20: error: two or more data types in declaration specifiers
>  static inline void void hsr_debugfs_rename(struct net_device *dev)
>
> So Removed one void.
>
> Signed-off-by: xiaofeng.yan <yanxiaofeng7@jd.com>

Acked-by: Taehee Yoo <ap420073@gmail.com>

I think the Fixes tag is needed.
You might have to send a v2 patch, which includes this Fixes tag.
Fixes: 4c2d5e33dcd3 ("hsr: rename debugfs file when interface name is changed")

Thank you!
Taehee Yoo