Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2198409ybl; Sun, 19 Jan 2020 21:32:12 -0800 (PST) X-Google-Smtp-Source: APXvYqw8cPG4wvSGURN/vLP7UHhB6NgQG3AZXubZYriWiNATxMKg9osudszMbeP4wtlEWnAdYAM+ X-Received: by 2002:aca:d484:: with SMTP id l126mr11455033oig.114.1579498332190; Sun, 19 Jan 2020 21:32:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579498332; cv=none; d=google.com; s=arc-20160816; b=hEA4jybz0BWf66eIiST4sHDUEhYiUG2FYAWwLwL+fiiMBGjutfTHAb23i+qJy3/8o0 876xNhvk4HIyZLmReqHD5yQvR/vz5o1wC9k8qsHFwIwRcB77erXLDyggOcWc8A1KeMq5 6KVErcGPXupoCHXhjgKfo6mkTuBZ/dYNY4TfUX2HkjHXVJqKaiDCMcGmXwLyLrINfgu0 VSMimVEbPnRVUYSUARDtDuLwKMFGT4diAdFxDtXdgAcFGwSTRx473ATGZc4Ld0voXVMd uQKtnD2RSla+JKENQCNi6r4FbjHr0avVtMr4EwY6ZSx9E3YnEVfdpkWHsuz2OUMS3dPk PtQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=x/Im7bSDMBWAjwjtmvgGmWhWwKPuaRjhZ2CMQESZcJw=; b=BJ1WvAbpLynCEAqt2gpMTZALXQ1pyTocYCVQmV/PmwNV0XMQASsTrNwfU9FgTti09M gDiIw1dgr2/Rm1WG1B8wjiMxW785/dQmnIyW22GJT6hAWGglY69oe5elQt1tceqV3715 mZbmoayptBUMxw0eKXYBOaKn7DAgPfis/eV8IP//KGbwyzbD/hZEj5sKHck0WKuy3bdU SRyObChIBVzdVzeYBvQBr9fBSKsdWSzv7GlZjrSXIuwP5rCk4GT/R83MluDpfEB4PT47 8XTroMLJG+iN3bYuSf05GA8djmXqZr/Tm1c9+bIxPkRnFgSvtWQ2rBhJl3OQVVQTkRJK 5Khg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Rp8IkP8y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n11si18283821otk.290.2020.01.19.21.32.00; Sun, 19 Jan 2020 21:32:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Rp8IkP8y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728042AbgATFaj (ORCPT + 99 others); Mon, 20 Jan 2020 00:30:39 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:40267 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725788AbgATFaj (ORCPT ); Mon, 20 Jan 2020 00:30:39 -0500 Received: by mail-pg1-f195.google.com with SMTP id k25so14945093pgt.7 for ; Sun, 19 Jan 2020 21:30:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=x/Im7bSDMBWAjwjtmvgGmWhWwKPuaRjhZ2CMQESZcJw=; b=Rp8IkP8y07rDor5ecGsa7KzPoRtNEX98aWRLdvuJUcVFNptUp2hQNtVzrBu8ogBekl nN5pxcMI6hvT5GqP6VIrVaPOYGm0FlD8TOKgua2V/BqOmVaaScA1sw+NquvFElBGqul4 nSXrvqzyvFVyo76hwyQhejVemPBzNFaRfGcq8JiBdj+MsMmkkQ55gLIE5FI2/B+upV3q soifZevzKlSefl5uqh2LMCpkqlVv/+uNGCicBuEZDQf2NhBFLL9djCmGuZD+t8tIcwLm snYGdOQBRsKWVya9IKUwooiPySmfw0gAgX43NtOWCYcxscb1FCSUQRGqRjMt0WD++NpX R2xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=x/Im7bSDMBWAjwjtmvgGmWhWwKPuaRjhZ2CMQESZcJw=; b=ls/+OFosBaoIwItANzUvR0PX0gizavVSqj/wSTGUtOToFtQp6LaPTd4ZUoG2ckWqoZ vUVSyfaqvOnbeMoGNcqvtx/pHBj7I6L5/imaFMFyIBg5O004I4sXVTUWqGsAsmRGuaAy 7jNTmRCL5HpreTYEKcUhBal+RMj171Hh0Myj2gs1XAqk0wmscIdMUD3OvVI8850+NJH2 EXCZEj5bl+BM2oNSsyZNNLAEhfO9+xHCk8TfrqX9Nw2E7OJtIiddIsbZOgC+asvJ3gbt D0Drwhaeqmyzpch8hsFqBjmT4e5zgysGOhkF+nwvUz3gyc/9U9vIMxDPms9F/Hq2DRvA ze3w== X-Gm-Message-State: APjAAAWENuJFk6S/viO2sPfTjY3QOwQjjitVJh0MmfxeYmxgtdie8ynf PJSX44AEBNTWqhMWSpuRaFs= X-Received: by 2002:a62:3343:: with SMTP id z64mr14954269pfz.150.1579498239051; Sun, 19 Jan 2020 21:30:39 -0800 (PST) Received: from localhost ([2401:fa00:8f:203:5bbb:c872:f2b1:f53b]) by smtp.gmail.com with ESMTPSA id u12sm35895493pfm.165.2020.01.19.21.30.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jan 2020 21:30:38 -0800 (PST) Date: Mon, 20 Jan 2020 14:30:36 +0900 From: Sergey Senozhatsky To: Yue Hu Cc: minchan@kernel.org, ngupta@vflare.org, sergey.senozhatsky.work@gmail.com, linux-kernel@vger.kernel.org, huyue2@yulong.com Subject: Re: [PATCH] zram: move backing_dev under macro CONFIG_ZRAM_WRITEBACK Message-ID: <20200120053036.GE7372@google.com> References: <20200120034155.6048-1-zbestahu@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200120034155.6048-1-zbestahu@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (20/01/20 11:41), Yue Hu wrote: > backing_dev is never used when not enable CONFIG_ZRAM_WRITEBACK and > it's introduced from writeback feature. So it's needless also affect > readability in that case. > > Signed-off-by: Yue Hu Looks good to me Reviewed-by: Sergey Senozhatsky -ss