Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2337806ybl; Mon, 20 Jan 2020 00:47:10 -0800 (PST) X-Google-Smtp-Source: APXvYqzvBYSF2cuZBnOHGy6WuhS8XBPumyDcvxNOkZnzoeqsuVmJ8IoXQwJVXtb7yIvkBpX9oDma X-Received: by 2002:aca:ea43:: with SMTP id i64mr12277870oih.30.1579510029989; Mon, 20 Jan 2020 00:47:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579510029; cv=none; d=google.com; s=arc-20160816; b=WLECwal4BFqLZnI62BZl+GvS0lKgmXDx2bWCv2Mvwt4vHNDsygSPtH22uzUw44Vcuz codUvAWD9WxEErCBGpE/4kCSm7X3p+M3fy33psy3CHaieA7xjbBjwtg9hafyIylfitHy BeaTZ4WQZp6xvYhlKQ/JBApWFejDHRpRuwWCrEYnSSiCadOkYe73dh19IkmqAGwjKCUA 50n3TgPWhC6MFdyImvMtTIRseIF9mc/FyXVsebanxfdJpHmXZgX2Y4KDBUYDVe1i+/np y4ySyMa+i9JBSvUXpMYl51nmOyzm5KIzJXKAbVoYnRNBsKZCGE0Gt9dqOeX/+vwIGp8i F71w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=T3VBXgudGBX+1YhJkjYRn+aVzCHBPKXBFKoHfjPT3kQ=; b=x/FzfdimxuOBggrja3xZEgb/qiTIHLGjKbwEp/ptKWoQNVh5cMyiE9vvf/2+0QFwZV uyT2fMQnLsn/gAkK+hVy3kefyyrOxM7joT3nfcuRWv76eqvnynCn4G+qxF5c+5RpOxT6 EXHISBu4TrZPsgVF3lZCuAtJ/VTLIgyKJdX3EDZ5iDVqcIvKU+AjnGZ+SgjqWnqvIXD8 E00ubCcX831n1cwve2ecd1iiK8WSvpOHWt/obscIHTPjvPANohBnoDtbilA4/XESfRqh 2JNYhMOb213H/S9VH2BP3R69INNT9wHNvwdjc4gAdv41X4XlAaHRwSNDPqcQfwLOqNre OwMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NLr8JbjZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x20si19987765otq.222.2020.01.20.00.46.58; Mon, 20 Jan 2020 00:47:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NLr8JbjZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726635AbgATIqH (ORCPT + 99 others); Mon, 20 Jan 2020 03:46:07 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:51071 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726125AbgATIqG (ORCPT ); Mon, 20 Jan 2020 03:46:06 -0500 Received: by mail-wm1-f67.google.com with SMTP id a5so13547435wmb.0 for ; Mon, 20 Jan 2020 00:46:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=T3VBXgudGBX+1YhJkjYRn+aVzCHBPKXBFKoHfjPT3kQ=; b=NLr8JbjZHjgx7BE0A831UWAgNffFK3Q+0xkPXxLjHt+Y3vaomowWx4yKaa9dDVbrMV IxADRn4G2HRnC6znUJY7LDNmgNQq/ZxkSqPre9WgMmXIjGmzjCHoD+vb3/NwgNQVH9Yo uN/viqlBQ7pePiF7oafLkVZllt2aVbh2AzYAScTcR7hTMg5mYA8/1/4OYwswwpGbzeRg L7usEcRcKmrsV14SnSk3vVEyZovjaZcEZh/9o3W2JSoM93cdRk1CjC432OLQtj/7znTC Mn/0qd0nQwbfLVyHouRD0Iu/I/+3+WMhEjOYBEoODf/g5JnJf2NOQ+GMFp3qIm3Cc+ho mRew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=T3VBXgudGBX+1YhJkjYRn+aVzCHBPKXBFKoHfjPT3kQ=; b=IoxlpXQhPSXEyFO/Ly2/7i+MUAkKwGR7uh+yWWjvBF6zw4E+7fYCN/vJUu4mZS8EwR ehVTc6U06le98eAaXMjMKdoxFJ8OzaBtQTvW8UIHXDk+/p/D6k6BA5/4zm2W4aJ45xkP EiduPwFv9K3GfF6V1lu5JHK0wFfyd8hqzH2Uy1sMk1U4tw0vqSb2V+xWcRhGctU7zlzB ShdKwzlAd3lKHjlHJfxjOapmGrL7ZZ6yj74Va8tEYGmWWK/KgaX3PymRKSX0pZlapeBi 3FKEuHTsAgOfLiX99pfaFClW3k72lw5eToSWBzwQGJps/88DlgefycaNM0cCdDMSQyST 8WQQ== X-Gm-Message-State: APjAAAUDXZ9H66MJY02taFA3OzjM3sRvuOm0k1f2Z566KrruzPp85bN4 IHudgwCDwKAyzhsJzdvH3oKCUzwuu9m2kUh/VzURxQ== X-Received: by 2002:a7b:c4cc:: with SMTP id g12mr18845651wmk.68.1579509964293; Mon, 20 Jan 2020 00:46:04 -0800 (PST) MIME-Version: 1.0 References: <20200113172245.27925-1-ardb@kernel.org> <20200120082501.GC26606@gmail.com> In-Reply-To: <20200120082501.GC26606@gmail.com> From: Ard Biesheuvel Date: Mon, 20 Jan 2020 09:45:53 +0100 Message-ID: Subject: Re: [GIT PULL 00/13] More EFI updates for v5.6 To: Ingo Molnar Cc: Ard Biesheuvel , linux-efi , Thomas Gleixner , Linux Kernel Mailing List , Anshuman Khandual , Arnd Bergmann , Dan Williams , Dave Young , Saravana Kannan Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 20 Jan 2020 at 09:25, Ingo Molnar wrote: > > > * Ard Biesheuvel wrote: > > > The following changes since commit 4444f8541dad16fefd9b8807ad1451e806ef1d94: > > > > efi: Allow disabling PCI busmastering on bridges during boot (2020-01-10 18:55:04 +0100) > > > > are available in the Git repository at: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git tags/efi-next > > > > for you to fetch changes up to 743c5dd59f7e4b9e7a28be6a8f0e8d03271a98ab: > > > > efi: Fix handling of multiple efi_fake_mem= entries (2020-01-13 10:41:53 +0100) > > > > ---------------------------------------------------------------- > > Third and final batch of EFI updates for v5.6: > > - A few touchups for the x86 libstub changes that have already been queued > > up. > > - Fix memory leaks and crash bugs in the EFI fake_mem driver, which may be > > used more heavily in the future for device-dax soft reservation (Dan) > > - Avoid RWX mappings in the EFI page tables when possible. > > - Avoid PCIe probing failures if the EFI framebuffer is probed first when > > the new of_devlink feature is active. > > - Move the support code for the old EFI memory mapping style into its only > > user, the SGI UV1+ support code. > > > > ---------------------------------------------------------------- > > Anshuman Khandual (1): > > efi: Fix comment for efi_mem_type() wrt absent physical addresses > > > > Ard Biesheuvel (7): > > efi/libstub/x86: use const attribute for efi_is_64bit() > > efi/libstub/x86: use mandatory 16-byte stack alignment in mixed mode > > x86/mm: fix NX bit clearing issue in kernel_map_pages_in_pgd > > efi/x86: don't map the entire kernel text RW for mixed mode > > efi/x86: avoid RWX mappings for all of DRAM > > efi/x86: limit EFI old memory map to SGI UV machines > > efi/arm: defer probe of PCIe backed efifb on DT systems > > > > Arnd Bergmann (1): > > efi/libstub/x86: fix unused-variable warning > > > > Dan Williams (4): > > efi: Add a flags parameter to efi_memory_map > > efi: Add tracking for dynamically allocated memmaps > > efi: Fix efi_memmap_alloc() leaks > > efi: Fix handling of multiple efi_fake_mem= entries > > > > Documentation/admin-guide/kernel-parameters.txt | 3 +- > > arch/x86/boot/compressed/eboot.c | 16 +- > > arch/x86/boot/compressed/efi_thunk_64.S | 46 ++---- > > arch/x86/boot/compressed/head_64.S | 7 +- > > arch/x86/include/asm/efi.h | 28 ++-- > > arch/x86/kernel/kexec-bzimage64.c | 2 +- > > arch/x86/mm/pat/set_memory.c | 8 +- > > arch/x86/platform/efi/efi.c | 40 +++-- > > arch/x86/platform/efi/efi_64.c | 190 ++++-------------------- > > arch/x86/platform/efi/quirks.c | 44 +++--- > > arch/x86/platform/uv/bios_uv.c | 164 +++++++++++++++++++- > > drivers/firmware/efi/arm-init.c | 107 ++++++++++++- > > drivers/firmware/efi/efi.c | 2 +- > > drivers/firmware/efi/fake_mem.c | 43 +++--- > > drivers/firmware/efi/memmap.c | 95 ++++++++---- > > include/linux/efi.h | 17 ++- > > 16 files changed, 471 insertions(+), 341 deletions(-) > > Thanks Ard, I've applied these and the 3 fixes in the second series to > tip:efi/core. It all merged nicely and looks good here. Let me know if > there's anything amiss. > Thanks Ingo, Apart from the mismatched parens in the commit log of the top commit, everything looks fine. It does appear that the KASAN fix is not 100% sufficient for mixed mode, so I'll need to apply another fix on top there, but we may have other things to fix during the cycle so I'll leave that for later.