Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 20 Jan 2020 10:50:27 +0100 (CET)
Message-Id: <20200120.105027.695127072650482577.davem@davemloft.net>
To:     moshe@mellanox.com
Cc:     jiri@mellanox.com, vikas.gupta@broadcom.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] devlink: Add health recover notifications on
 devlink flows
From:   David Miller <davem@davemloft.net>
In-Reply-To: <1579446268-26540-1-git-send-email-moshe@mellanox.com>
References: <1579446268-26540-1-git-send-email-moshe@mellanox.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Moshe Shemesh <moshe@mellanox.com>
Date: Sun, 19 Jan 2020 17:04:28 +0200

> Devlink health recover notifications were added only on driver direct
> updates of health_state through devlink_health_reporter_state_update().
> Add notifications on updates of health_state by devlink flows of report
> and recover.
> 
> Fixes: 97ff3bd37fac ("devlink: add devink notification when reporter update health state")
> Signed-off-by: Moshe Shemesh <moshe@mellanox.com>
> Acked-by: Jiri Pirko <jiri@mellanox.com>

I really dislike forward declarations and almost all of the time they are
unnecessary.

Could you please just rearrange the code as needed and resubmit?

Thank you.