Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jose Abreu <Jose.Abreu@synopsys.com>
To:     Russell King - ARM Linux admin <linux@armlinux.org.uk>
CC:     Andrew Lunn <andrew@lunn.ch>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Joao Pinto <Joao.Pinto@synopsys.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [RFC net-next] net: phy: Add basic support for Synopsys XPCS
 using a PHY driver
Thread-Topic: [RFC net-next] net: phy: Add basic support for Synopsys XPCS
 using a PHY driver
Thread-Index: AQHVyhMHPh1TkUf6pU+JUVzLFdFzk6fomWeAgAAAjSCAAAp/gIAKvyCAgAAHGACAAANl4A==
Date:   Mon, 20 Jan 2020 11:07:23 +0000
Message-ID: <BN8PR12MB32663612E58060077996670ED3320@BN8PR12MB3266.namprd12.prod.outlook.com>
References: <4953fc69a26bee930bccdeb612f1ce740a4294df.1578921062.git.Jose.Abreu@synopsys.com>
 <20200113133845.GD11788@lunn.ch>
 <BN8PR12MB32666F34D45D7881BDD4CAB3D3350@BN8PR12MB3266.namprd12.prod.outlook.com>
 <20200113141817.GN25745@shell.armlinux.org.uk>
 <BN8PR12MB3266EC7870338BA4A65E8A6CD3320@BN8PR12MB3266.namprd12.prod.outlook.com>
 <20200120105020.GB25745@shell.armlinux.org.uk>
In-Reply-To: <20200120105020.GB25745@shell.armlinux.org.uk>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: synopsys.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: dead3062-a74b-46e7-1b4b-08d79d98ed30
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jan 2020 11:07:23.4418
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: c33c9f88-1eb7-4099-9700-16013fd9e8aa
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Paj8ILY9flkdatAaO/SNRS9idQG4mFN5/pWwNlx1yUTMl452nH9yFAFBHC5xtWC+TqHXFzSQKUVzt0wsZIwfGQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3268
X-OriginatorOrg: synopsys.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Date: Jan/20/2020, 10:50:20 (UTC+00:00)

> On Mon, Jan 20, 2020 at 10:31:17AM +0000, Jose Abreu wrote:
> > From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
> > Date: Jan/13/2020, 14:18:17 (UTC+00:00)
> >=20
> > > I've recently suggested a patch to phylink to add a generic helper to
> > > read the state from a generic 802.3 clause 37 PCS, but I guess that
> > > won't be sufficient for an XPCS.  However, it should give some clues
> > > if you're intending to use phylink.
> >=20
> > So, I think for my particular setup (that has no "real" PHY) we can hav=
e=20
> > something like this in SW PoV:
> >=20
> > stmmac -> xpcs -> SW-PHY / Fixed PHY
> >=20
> > - stmmac + xpcs state would be handled by phylink (MAC side)
> > - SW-PHY / Fixed PHY state would be handled by phylink (PHY side)
> >=20
> > This would need updates for Fixed PHY to support >1G speeds.
>=20
> You don't want to do that if you have 1G SFPs.  Yes, you *can* do it
> and make it work, but you miss out completely on the fact that the
> link is supposed to be negotiated across the SFP link for 1G speeds,
> and then you're into the realms of having to provide users ways to
> edit the DT and reboot if the parameters at the link partner change.

You may have missed my answer to Andrew so I'll quote it here:

---
[...]

My current setup is this:

Host PC x86 -> PCI -> XGMAC -> XPCS -> SERDES 10G-BASE-R -> QSFP+

The only piece that needs configuration besides XGMAC is the XPCS hereby=20

I "called" it a PHY [...]
---

So, besides not having a DT based setup to test changes, I also don't have=
=20
access to SFP bus neither SERDES ... As you suggested, I would like to=20
integrate XPCS with PHYLINK in stmmac but I'm not entirely sure on how to=20
implement the remaining connections as the connect_phy() callbacks will=20
fail because the only MMD device in the bus will be XPCS. That's why I=20
suggested the Fixed PHY approach ...

---
Thanks,
Jose Miguel Abreu