Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2463142ybl; Mon, 20 Jan 2020 03:28:20 -0800 (PST) X-Google-Smtp-Source: APXvYqyJ2wL94GxOwNZvzht97pHY95Z7T/xxjNPooxl1//mJrESxPXDuMoFsPvBKx36AH5MUofxZ X-Received: by 2002:a9d:6e82:: with SMTP id a2mr15212147otr.336.1579519700050; Mon, 20 Jan 2020 03:28:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579519700; cv=none; d=google.com; s=arc-20160816; b=hRDvb4RYP/fIQRWzgCa+bgVvEy7cnuFrivxR+hScScnmuKcZWDu+43LFsatrATGfMT QTfGTeh6fj/G9pUes8vOVl0vPar26hzuHJAPt4fyYM3s+FXtmY0I5Z9QsWGlZqypBpJy yz/b+kL0FtacuwpwJp6xwzrEutO4amdqmkJjYC3QatMYJ7NBLHYluIniC2qipb9+ms2R jh3OMnUOtb2/R7jTAt4cti52UvZvVlIhVTeP0BL+KT5jwL+FEwKj7y+oFVw3EOeIbG3y vQG4Xao4394fb8AgE5z3DIQJ5IPHxdgoMTT4tiUAZsrEpMjr6OgIlNtKrHoz0V6IMffp ROSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=+QrjNjPG/DY5+TEdC5uJWY8ByCtGQfHlt+6TWxLSsd4=; b=VzQTaxC+roIFKbKaogCyuLHFmjYQPydqGCL48y6s9qhkBNiJXjHu7uKxXyUDzbfEwd VJ5tpPT+xV5Ew5xGLla9k6nLSCB0pifVFvfcAIQnRaP6+kW4oieppCsuzaYpKPCixciE 1Ovx6ro+9HjJrj6W4c5HfA2nOtGGPrlZwQbNNkUESli6oIaWVNr524A2+3uyO06ie7Zv cLS53xysbgKsk4xB8ttSM8u5/NGJxRUDZhMPG1xmR6CraKHRGoUw1ZZVz1NjiFIdSNRr NcPIm/OFHJ1Uw1FtY2+FEpU01rZvouyFOeia4LvFyEc8d/tOS7ZtWx3n2WecXyDaNSgf xjew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zoiGWUQL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u18si22628080otg.201.2020.01.20.03.28.08; Mon, 20 Jan 2020 03:28:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zoiGWUQL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727289AbgATL0Q (ORCPT + 99 others); Mon, 20 Jan 2020 06:26:16 -0500 Received: from mail-vs1-f67.google.com ([209.85.217.67]:43338 "EHLO mail-vs1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727032AbgATL0P (ORCPT ); Mon, 20 Jan 2020 06:26:15 -0500 Received: by mail-vs1-f67.google.com with SMTP id s16so18697829vsc.10 for ; Mon, 20 Jan 2020 03:26:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+QrjNjPG/DY5+TEdC5uJWY8ByCtGQfHlt+6TWxLSsd4=; b=zoiGWUQLncvGKY1aPONfIIVo9eJD/fSbxnAqre/srpx1AIsJDP8FjgE7e3GNOo6Av5 /M2+iSTfyjh44HEBZLB41qjpf2AiUyagQS8CPwv9iImXbf9jDf7KiXWd3hfVZTZGgpkR QOW1jHlxTMAQE15YHuWbSuH5FF40TTvlEO/8TYyjJBOj+dAdF9AWDUwIdfRjDe1RWqDH CquW7dewJPQ9rbFJroufRB8QhV1RvqliTijL3g37FKxzWnbEWkXItiLMBCCgk9BFIAEL Vdg+5CMdnTkOXnAPyQS91moWacc2LqFV4mJsWT1mAjsWklRbdA4xUtD0hIBwh77YJGHZ hMVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+QrjNjPG/DY5+TEdC5uJWY8ByCtGQfHlt+6TWxLSsd4=; b=h/079ZiN3AZok0zG23x9MwRkOobr62vmYqbSNuz0/u5iw8eXddt5xqI+6F9WPIeTyp Unvlt2pJnZArbkbOJdnH37ibY3t+Mq6fJXoudDQ37s435kM8pFP3hiRtVANCFlOhVVD0 QTau44Gw1CrUnKp2xPvLavnJkKQJpAM7tHOLpjyEOWr91CDgXDJ2iefjjcBwEFcyihZi kIZmtI8bwGEzlVH25I4OEelow/LNWV0fN6U8Z3P0gXHKZKpz1DXGuuQoWS+syUyeCIXB OieaNr18qNscfGG268OIm7AWj+FoRQ4I5bK9HJ6/xdrmjfNo7HRspzS6m1ghxZMJP2My NOZQ== X-Gm-Message-State: APjAAAWa9UANJab16/LxU93xE54ZubWVGeYSH2AVxCFauLeuO92CmJHH iuixvl105XLm/6btqgA98oWgqbYo5XRsDbqoIT0tvQ== X-Received: by 2002:a67:314e:: with SMTP id x75mr11583092vsx.35.1579519574713; Mon, 20 Jan 2020 03:26:14 -0800 (PST) MIME-Version: 1.0 References: <20200120031023.32482-1-zhang.chunyan@linaro.org> <20200120033223.897-1-zhang.chunyan@linaro.org> <65f7272c-ecea-03de-433b-21ba2e672d20@intel.com> In-Reply-To: From: Ulf Hansson Date: Mon, 20 Jan 2020 12:25:38 +0100 Message-ID: Subject: Re: [PATCH v2] mmc: sdhci: fix an issue of mixing different types To: Chunyan Zhang Cc: Adrian Hunter , Faiz Abbas , Nathan Chancellor , Chunyan Zhang , "linux-mmc@vger.kernel.org" , clang-built-linux@googlegroups.com, Linux Kernel Mailing List , kbuild test robot Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 20 Jan 2020 at 09:14, Chunyan Zhang wrote: > > On Mon, 20 Jan 2020 at 15:15, Adrian Hunter wrote: > > > > On 20/01/20 5:32 am, Chunyan Zhang wrote: > > > Fix an issue reported by sparse, since mixed types of parameters are > > > used on calling dmaengine_prep_slave_sg(). > > > > > > Fixes: 36e1da441fec (mmc: sdhci: add support for using external DMA devices) > > > > That commit number is only in next > > Ok, so should this line be removed? Normally yes, because I may rebase my next branch. However, at this point in time I am not planning for a rebase, so let's keep it. > > > > > > Reported-by: kbuild test robot > > > Signed-off-by: Chunyan Zhang > > > Reviewed-by: Nathan Chancellor > > > > Acked-by: Adrian Hunter > > Thank you! > > Chunyan [...] Applied for next, thanks! Kind regards Uffe