Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191217104025.23318-1-peter.ujfalusi@ti.com>
In-Reply-To: <20191217104025.23318-1-peter.ujfalusi@ti.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Mon, 20 Jan 2020 13:05:09 +0100
Message-ID: <CAMuHMdUPhabZrXJ3UqSVTdy2aWf6VG27q287MizKJ5q5tyRnwA@mail.gmail.com>
Subject: Re: [PATCH] media: rcar_drif: Use dma_request_chan() instead dma_request_slave_channel()
To:     Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Ramesh Shanmugasundaram <rashanmu@gmail.com>,
        Vinod <vkoul@kernel.org>,
        Linux Media Mailing List <linux-media@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Dec 17, 2019 at 11:41 AM Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:
> dma_request_slave_channel() is a wrapper on top of dma_request_chan()
> eating up the error code.
>
> By using dma_request_chan() directly the driver can support deferred
> probing against DMA.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

One comment below.

> --- a/drivers/media/platform/rcar_drif.c
> +++ b/drivers/media/platform/rcar_drif.c
> @@ -275,10 +275,10 @@ static int rcar_drif_alloc_dmachannels(struct rcar_drif_sdr *sdr)
>         for_each_rcar_drif_channel(i, &sdr->cur_ch_mask) {
>                 struct rcar_drif *ch = sdr->ch[i];
>
> -               ch->dmach = dma_request_slave_channel(&ch->pdev->dev, "rx");
> -               if (!ch->dmach) {
> +               ch->dmach = dma_request_chan(&ch->pdev->dev, "rx");
> +               if (IS_ERR(ch->dmach)) {
>                         rdrif_err(sdr, "ch%u: dma channel req failed\n", i);

Now there is an error code, you might (1) want to print it, and (2) only
do so when it is not due to probe deferral:

        if (PTR_ERR(ch->dmach) != -EPROBE_DEFER)
                rdrif_err(sdr, "ch%u: dma channel req failed %pe\n",
i, ch->dmach);

> -                       ret = -ENODEV;
> +                       ret = PTR_ERR(ch->dmach);
>                         goto dmach_error;
>                 }

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds