Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2509925ybl; Mon, 20 Jan 2020 04:22:48 -0800 (PST) X-Google-Smtp-Source: APXvYqyYnrzc2JkUWQ7c6bquyQgEdhfwAe3nit1rKAdbRymMlguGdchCbHh83QxNt/pWhC65h5C7 X-Received: by 2002:aca:f484:: with SMTP id s126mr12168030oih.48.1579522968261; Mon, 20 Jan 2020 04:22:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579522968; cv=none; d=google.com; s=arc-20160816; b=BQ9cNd1O9ELMletMEyZ77NIIcUEoxs5B92aOFOTiATCtfDuiKgmBsB1FFWNbnbdbCi TBFTFn9EcKN/plboxljbhxCyMF/dkDa6R09Q+N8tzTRNv3HfMB73hs0vUsEpLEUyskFO Vr/8DxxMhUQQj/WBvwZRpL86zCpYhjCJyK77BMbjcqUeifF5PhZ6IA0i5tH7FMPK8e7L RbJ353DYPXf73a4RroGDL2R5IdNEIyNJ01+pwXb2EaF2Ff/Q6iryxeoGcOX8JU+REQoN /5HHGip9lGvMieHVqIXPfiKABmZquQS/ZKxOqTLy/QcrOpmm9AaZbbIMoqYii33SjODq vZ5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=qI990KT6RiDdZrdHhTBVoD7dMzhylOgKCjxz3lipcnI=; b=j3f1iaCTRXOeEL+Tq8AzSYlpv5R5rS1leBcu3tEGOFjcZzWON7Nx/uUNNCI3iKzCH3 Do4N8APHHaMWHgU8wP/cjkMK9U1JWWw5WMHu/bfZA2DJH77HjeCWpm3YlmiJ2p6F8E9D JJoLRwzwsh6pmv7qD0vX6lpBGvT+nEUp0wJUVd5U8pV9UyN+zOm7VIbvplgaIdeo1rss RSOucpRHE35wu78ltlo8CpSPBVhMW55E1YgGe58eHPWXFMNKRSB/qnbQ+J6IMOaP6RJf W8Jg3SWEeqagYZIpQ/sWriLWDYtt8snBlultaxeR+9JyY8xFQqhaT2UL9RQ7Rlp/vyJ3 IbgA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l19si16926074oii.54.2020.01.20.04.22.35; Mon, 20 Jan 2020 04:22:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727573AbgATMVk (ORCPT + 99 others); Mon, 20 Jan 2020 07:21:40 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:56248 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726589AbgATMVk (ORCPT ); Mon, 20 Jan 2020 07:21:40 -0500 Received: from localhost (82-95-191-104.ip.xs4all.nl [82.95.191.104]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 0E59614E20F85; Mon, 20 Jan 2020 04:21:37 -0800 (PST) Date: Mon, 20 Jan 2020 13:21:36 +0100 (CET) Message-Id: <20200120.132136.1992070505971817725.davem@davemloft.net> To: xiaofeng.yan2012@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ap420073@gmail.com, yanxiaofeng7@jd.com Subject: Re: [PATCH v2] hsr: Fix a compilation error From: David Miller In-Reply-To: <20200120062639.3074-1-xiaofeng.yan2012@gmail.com> References: <20200120062639.3074-1-xiaofeng.yan2012@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 20 Jan 2020 04:21:39 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "xiaofeng.yan" Date: Mon, 20 Jan 2020 14:26:39 +0800 > From: "xiaofeng.yan" > > A compliation error happen when building branch 5.5-rc7 > > In file included from net/hsr/hsr_main.c:12:0: > net/hsr/hsr_main.h:194:20: error: two or more data types in declaration specifiers > static inline void void hsr_debugfs_rename(struct net_device *dev) > > So Removed one void. > > Fixes: 4c2d5e33dcd3 ("hsr: rename debugfs file when interface name is changed") > Signed-off-by: xiaofeng.yan > Acked-by: Taehee Yoo Applied, thank you.