Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Leonard Crestez <leonard.crestez@nxp.com>
To:     Peng Fan <peng.fan@nxp.com>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>
CC:     "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
        "will@kernel.org" <will@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        dl-linux-imx <linux-imx@nxp.com>,
        "olof@lixom.net" <olof@lixom.net>,
        Aisheng Dong <aisheng.dong@nxp.com>,
        Abel Vesa <abel.vesa@nxp.com>,
        "krzk@kernel.org" <krzk@kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/4] soc: imx: increase build coverage for imx8 soc driver
Thread-Topic: [PATCH 0/4] soc: imx: increase build coverage for imx8 soc
 driver
Thread-Index: AQHVzB/hVXSait8oKkG3c6qn/lfwPw==
Date:   Mon, 20 Jan 2020 12:45:03 +0000
Message-ID: <VI1PR04MB70231E81AB33489264502009EE320@VI1PR04MB7023.eurprd04.prod.outlook.com>
References: <1579146280-1750-1-git-send-email-peng.fan@nxp.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 75f03ec9-99eb-4d71-dac5-08d79da69203
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jan 2020 12:45:03.4887
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +ddm25sp5eT8ScQre+U168nfSQXaGhg+vEGk1HispNjgHfblfPx8ZOybTikZjAj/+cxbcC6x3u1G+eNHL1/67A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4365
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 16.01.2020 05:48, Peng Fan wrote:=0A=
> From: Peng Fan <peng.fan@nxp.com>=0A=
> =0A=
> Rename soc-imx8.c to soc-imx8m.c which is for i.MX8M family=0A=
> Add SOC_IMX8M for build gate soc-imx8m.c=0A=
> Increase build coverage for i.MX SoC driver=0A=
> =0A=
> Peng Fan (4):=0A=
>    soc: imx: Kconfig: add SOC_IMX8M entry=0A=
>    arm64: defconfig: Enable CONFIG_SOC_IMX8M by default=0A=
>    soc: Makefile: increase build coverage for i.MX=0A=
>    soc: imx: Use CONFIG_SOC_IMX8M as build gate=0A=
> =0A=
>   arch/arm64/configs/defconfig                | 1 +=0A=
>   drivers/soc/Makefile                        | 2 +-=0A=
>   drivers/soc/imx/Kconfig                     | 8 ++++++++=0A=
>   drivers/soc/imx/Makefile                    | 2 +-=0A=
>   drivers/soc/imx/{soc-imx8.c =3D> soc-imx8m.c} | 0=0A=
>   5 files changed, 11 insertions(+), 2 deletions(-)=0A=
>   rename drivers/soc/imx/{soc-imx8.c =3D> soc-imx8m.c} (100%)=0A=
=0A=
I applied your patches and compiletest failed for me on x86:=0A=
=0A=
../drivers/soc/imx/gpcv2.c: In function =91imx_gpcv2_probe=92:=0A=
../drivers/soc/imx/gpcv2.c:561:21: error: =91SZ_4K=92 undeclared (first use=
 =0A=
in this function)=0A=
    .max_register   =3D SZ_4K,=0A=
                      ^~~~~=0A=
../drivers/soc/imx/gpcv2.c:561:21: note: each undeclared identifier is =0A=
reported only once for each function it appears in=0A=
=0A=
It seems that on x86 <linux/sizes.h> needs to be included explicitly =0A=
while on arm it is already included indirectly through arch headers. Fix =
=0A=
is very simple:=0A=
=0A=
diff --git drivers/soc/imx/gpcv2.c drivers/soc/imx/gpcv2.c=0A=
index b0dffb06c05d..6cf8a7a412bd 100644=0A=
--- drivers/soc/imx/gpcv2.c=0A=
+++ drivers/soc/imx/gpcv2.c=0A=
@@ -14,6 +14,7 @@=0A=
  #include <linux/pm_domain.h>=0A=
  #include <linux/regmap.h>=0A=
  #include <linux/regulator/consumer.h>=0A=
+#include <linux/sizes.h>=0A=
  #include <dt-bindings/power/imx7-power.h>=0A=
  #include <dt-bindings/power/imx8mq-power.h>=0A=
=0A=
---=0A=
=0A=
My test looks like this:=0A=
=0A=
make O=3Dbuild_compiletest defconfig=0A=
make O=3Dbuild_compiletest allmodconfig=0A=
echo CONFIG_COMPILE_TEST=3Dy >> build_compiletest/.config=0A=
make O=3Dbuild_compiletest "$@"=0A=
=0A=
Other than this:=0A=
=0A=
Reviewed-by: Leonard Crestez <leonard.crestez@nxp.com>=0A=