Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2639008ybl; Mon, 20 Jan 2020 06:42:31 -0800 (PST) X-Google-Smtp-Source: APXvYqyd4Vry1ghO/aqHDZnaH2W1+ORunM9rtSRLMDCAxnrtj+y45X7ySjeDoD8+4IOD0OYNVPzM X-Received: by 2002:aca:ef82:: with SMTP id n124mr13183470oih.88.1579531350871; Mon, 20 Jan 2020 06:42:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579531350; cv=none; d=google.com; s=arc-20160816; b=jXcqSr6YY5tAvEyQa4vB023kEhceM1vGiq+iu6TmaSRijKHn57GTtSGeq9ndGXgGI/ VRZv6K/9QRMLVEingWWtHwkHAXnJzhdhVacyPIF+WhdjHYXgABr1BbiiVQH3tqNk/5V/ +omPMbPFcm8dzlJzDdpXDPEAFHDJ8Fk+w2VNhUeP3qbqaML86wTAoq0I0FXWoxkmvNCe jv+N/FKkPugfgPdT8qRe5cG3jwSuXWey3VMn1bwxTO0Zg/4566frbcSQDwYMxeqPwTct ZVlWJmhK6XWGBZ6PNgpDdon1YRjfmevetcL2C3t7JeGJ2JnSNTcuA4Ht7kz7RR5qksd2 QxyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=4vIHUP9As2MHt/JTSJQoVlkdeNmF2zWPaSmNysm1Qn8=; b=no6bgpa1utSbFKQGoVQigOB5ZoMpbQX+Zgpi6izlxp5hGBSRKtG/zAGNNxmJSaWRp0 rFrMi6Ji+mVx5DhRIj6dAemZc9GtNPWmqKSA2OEmr/VhBS5jSoIO5l4mwoH55fwOiC0t OXUE5YOBXBmv0tN5Ea3ULRKYsPo1ZOrxbdaQrkdSDiT8fGhWPReTnn9XAWcIOzQAzNiA NgRENsRokAKLiiy0MSRiagQBtA/AM+5j0cjk/pH0Ilwc2uEG9355opvf/XMRL2JDgVMt KUM+Kjhr440F2I5a1NsZh+WK1l8kSXSaylD2dPtFd6FkCO4cc3Mo0D+lAhcGD4giZZ5D gkoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=temperror (dns failure for signature) header.i=@infradead.org header.s=bombadil.20170209 header.b=E2iEv9VX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k15si17496881oij.134.2020.01.20.06.42.18; Mon, 20 Jan 2020 06:42:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=temperror (dns failure for signature) header.i=@infradead.org header.s=bombadil.20170209 header.b=E2iEv9VX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728811AbgATOl0 (ORCPT + 99 others); Mon, 20 Jan 2020 09:41:26 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:59090 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726738AbgATOl0 (ORCPT ); Mon, 20 Jan 2020 09:41:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=4vIHUP9As2MHt/JTSJQoVlkdeNmF2zWPaSmNysm1Qn8=; b=E2iEv9VXGSdatAc8hrd7dKhN6 mi3zF/s/rHUeynfPDWwXxwIz6Klpgs1KdfzSA/Rbz0F5rZWQhjwaEOTeDXgBAaTLoECb7iwHNKiOw gc4OLOvoedumQN3JBP+iGJGPdh0hkZslBHd6s5xLz0VQokrrJN7T2o80hxuLRlBQXSBxiN/MY3rSN WrEMQn5Q7f8EKzjbV06mn6k/SO61Yax+mHLCGb5kpE/hBa0qOIy2185/wg1uqgnkFlXtBX9JAuVtD zxDWnGMpCJYA8KCnbaoV6VBmh2460Sbx0v7BpgFunUBauIL/L5R4+hcacPDl6cblrWBU77yuAMRTf uzm+DqXKQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1itYEV-0001Bj-4K; Mon, 20 Jan 2020 14:40:51 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id BC36E3010D2; Mon, 20 Jan 2020 15:39:09 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 643E92020D90A; Mon, 20 Jan 2020 15:40:48 +0100 (CET) Date: Mon, 20 Jan 2020 15:40:48 +0100 From: Peter Zijlstra To: Marco Elver Cc: paulmck@kernel.org, andreyknvl@google.com, glider@google.com, dvyukov@google.com, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, mark.rutland@arm.com, will@kernel.org, boqun.feng@gmail.com, arnd@arndb.de, viro@zeniv.linux.org.uk, christophe.leroy@c-s.fr, dja@axtens.net, mpe@ellerman.id.au, rostedt@goodmis.org, mhiramat@kernel.org, mingo@kernel.org, christian.brauner@ubuntu.com, daniel@iogearbox.net, cyphar@cyphar.com, keescook@chromium.org, linux-arch@vger.kernel.org Subject: Re: [PATCH 3/5] asm-generic, kcsan: Add KCSAN instrumentation for bitops Message-ID: <20200120144048.GB14914@hirez.programming.kicks-ass.net> References: <20200120141927.114373-1-elver@google.com> <20200120141927.114373-3-elver@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200120141927.114373-3-elver@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 20, 2020 at 03:19:25PM +0100, Marco Elver wrote: > Add explicit KCSAN checks for bitops. > > Note that test_bit() is an atomic bitop, and we instrument it as such, Well, it is 'atomic' in the same way that atomic_read() is. Both are very much not atomic ops, but are part of an interface that facilitates atomic operations.