Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2711544ybl; Mon, 20 Jan 2020 08:00:43 -0800 (PST) X-Google-Smtp-Source: APXvYqwTw4jD3fah8n/mRsG3iMN7bkgelFJmKmHgYVHKJfft+lOaQAkpO+TkC4UUGp4ZMUzME05L X-Received: by 2002:a9d:c02:: with SMTP id 2mr40642otr.183.1579536043332; Mon, 20 Jan 2020 08:00:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579536043; cv=none; d=google.com; s=arc-20160816; b=RJQg+siQ2odozcJjEaKnfaoBW0TrvPuW4uxct5he/3nX1ouvEfHApkuBAaiHGpV+KA fXu2elhs+kTh4Jh0Xa2o5D5MnU2PNZItbYJ26rwOEXJnW0fJPVE0kdSuUml3YHBz5Nzr W+o/QR3CFonwCW6jaH5QgX2dtvZ76+Z/Re8JgAWjo5dqEPgU+bK0YIokqUsTu5VKgbGk a29XUiqkoWMDQI7Byu7Uvww+1GPnxmHDDvmehS86uUjPjnzPgznEGYJsrhVxBNDI5pIb j47ukHVndNaAvR4EmiJR3Y0AHciwjIQ2MsCl3t1OXOFqM8Q/4+EQ8OFm8EKO77khicaz fENA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=hCx0FkOyPUAD6FImSxkekqB+LP9ak15a5zOVHzRkbmQ=; b=UYEwbCAqhza28ubev5aFTOh6vAmTRXv4VdW0eBe30Iw2CTCEmFpWVlcfY5sVxJH6Mu YfbM7EOgM0Nf2NZPpVVtn53dn1A5wdaut0nLKZQ7pKAorWRyHwr/FqqTUQA/jO8fNLS5 JSLyZMNEH6VLzGzfLtXbxfmcnDuNpSIY248r4DPkvyUDPb9Vp9bsMx+F7rv0RIXKxhzS 6GOW4X5Yq2BibmTbSY1Pu00nUX1j5VQrIU5QvaSDye91zFPpGl6ilUXaYWW1Sm6BnwBR 2Dikt4JmUn+cR4joDZbhdKjMozXHlBS4tqQDZZTOIIT1J+w5f3ma9SlZ2xCeZkUAYKus LvkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="fP/G9x+L"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e9si20428468otk.318.2020.01.20.08.00.30; Mon, 20 Jan 2020 08:00:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="fP/G9x+L"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729092AbgATP6Q (ORCPT + 99 others); Mon, 20 Jan 2020 10:58:16 -0500 Received: from mail-ed1-f65.google.com ([209.85.208.65]:35147 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726876AbgATP6P (ORCPT ); Mon, 20 Jan 2020 10:58:15 -0500 Received: by mail-ed1-f65.google.com with SMTP id f8so29955826edv.2; Mon, 20 Jan 2020 07:58:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hCx0FkOyPUAD6FImSxkekqB+LP9ak15a5zOVHzRkbmQ=; b=fP/G9x+L9PkgABveHZWoY9IaNc5ecTNODt99ULgbvz4WSGj+RnBE9AphLW93GtkZ3F 1JJaEFbixiJRZPRtcGTck/aS3dEh5qIPQaxMRxB2EgifHFzu9s6KQfhgI9PzfbSboilB IXo01B8GkrtVd7FFkOOl3Up1RM4ZRrWx+OJ/9NSKwrc9AngKrSVo/8izMGXL+UvzS3Vd 8LvD+ure5A3IoxOcaX7RuFrYapJxo/1o86BbhRX+6EtEA167ic6Ecytm9lh9h2EJWyP8 px4zrGg8O6XS7YbF8EQTkILa04SzPKDDcjT9b8yvTyKs/0yLzcZZ2s/azXsJbH20itbq zN5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hCx0FkOyPUAD6FImSxkekqB+LP9ak15a5zOVHzRkbmQ=; b=NFRZn6ILXyfVszk1r4EXfCzAe1yOtlSwHot9uMUA74Lcq6vvedec9TV+f7q/ajb2tu 9rocu8kD2JbEsIvw8N4A76Wus0cxDccP8F7979tWnx/b175UuoiUxy1q5HIzQrHe8Y0M ZhTbYxzam9sc9lM665As4p/SGr29tW9gE0JC9BtnFILkSecLHddmgm72zZOz88YRwZi6 7oDB/8z7IODwDhkoWoOWIpmJWurY3D/mKRP75duvRiC7ctriWlj9cLX7odY1AOjbo6pu FMeuDqJ3jHG35frrLevx+y7r0AdeC0pbwTeD8ej3r5d84GofJPBX0K/mkuMNSryD8mVu kG9w== X-Gm-Message-State: APjAAAWE0jSGIsYTKbOAtM8Ex1f+lVxjT4SOFMOwTI4lqNj8l8k3To+B NPlPGjMHItmAid8AQb/j7IU= X-Received: by 2002:a17:906:7006:: with SMTP id n6mr53213ejj.1.1579535893494; Mon, 20 Jan 2020 07:58:13 -0800 (PST) Received: from [192.168.2.145] (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.googlemail.com with ESMTPSA id r9sm1162950ejx.31.2020.01.20.07.58.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jan 2020 07:58:12 -0800 (PST) Subject: Re: [alsa-devel] [PATCH 2/9] ASoC: tegra: add support for CIF programming To: Sameer Pujar , perex@perex.cz, tiwai@suse.com, robh+dt@kernel.org Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, atalambedu@nvidia.com, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, jonathanh@nvidia.com, viswanathl@nvidia.com, sharadg@nvidia.com, broonie@kernel.org, thierry.reding@gmail.com, linux-tegra@vger.kernel.org, rlokhande@nvidia.com, mkumard@nvidia.com, dramesh@nvidia.com References: <1579530198-13431-1-git-send-email-spujar@nvidia.com> <1579530198-13431-3-git-send-email-spujar@nvidia.com> From: Dmitry Osipenko Message-ID: Date: Mon, 20 Jan 2020 18:58:11 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <1579530198-13431-3-git-send-email-spujar@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Sameer, 20.01.2020 17:23, Sameer Pujar пишет: [snip] > Tegra30 and Tegra124 have an identical CIF programming helper function. [snip] > -#define TEGRA124_AUDIOCIF_CTRL_FIFO_THRESHOLD_SHIFT 24 > -#define TEGRA124_AUDIOCIF_CTRL_FIFO_THRESHOLD_MASK_US 0x3f > -#define TEGRA124_AUDIOCIF_CTRL_FIFO_THRESHOLD_MASK (TEGRA124_AUDIOCIF_CTRL_FIFO_THRESHOLD_MASK_US << TEGRA124_AUDIOCIF_CTRL_FIFO_THRESHOLD_SHIFT) > - > -/* Channel count minus 1 */ > -#define TEGRA30_AUDIOCIF_CTRL_AUDIO_CHANNELS_SHIFT 24 > -#define TEGRA30_AUDIOCIF_CTRL_AUDIO_CHANNELS_MASK_US 7 > -#define TEGRA30_AUDIOCIF_CTRL_AUDIO_CHANNELS_MASK (TEGRA30_AUDIOCIF_CTRL_AUDIO_CHANNELS_MASK_US << TEGRA30_AUDIOCIF_CTRL_AUDIO_CHANNELS_SHIFT) The AUDIOCIF_CTRL bitfields are not the same on T30 and T124, why are you claiming that programming is identical? Have you actually tried to test these patches on T30?