Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2832816ybl; Mon, 20 Jan 2020 10:11:09 -0800 (PST) X-Google-Smtp-Source: APXvYqwRQmavRaqcq75At3mETwvcw1i1hGwQ25GikhHhzCIFiXgE0jS+u8+97ghMGE8xzRfx5wnT X-Received: by 2002:aca:568f:: with SMTP id k137mr87741oib.63.1579543869406; Mon, 20 Jan 2020 10:11:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579543869; cv=none; d=google.com; s=arc-20160816; b=x0H9YprihMcvYB0ygLusG2K2Sw1PuUIaeg61ayK6LLSBAAhPi2/0a0vyohyDRrqnil cyfy+VoMUEHbn7Z0DvG/xp04K8fR8UzTN18WyCC0Q3O/y8SR7mUf+f9Re3M0nJeO9VAv ldiPhrSdfGALS2DSsOIOpH/psEzJDoohIb9vNLbEii5I5d+wCJp5RcAJNIuiNBXHCHZ2 fFNJF35m7Ao0Uc2LXZHIKYmt1XzaSm1JBUuYuQLxIreDdg5rHn9RMHbLpcqWkiNAmk1E PLq0rA1dsZDYq3p3+BOs32U0d3enCk7wFFy1BzAsf5ERK9vQw1cx0qAtxEdE+B3k8wEL ECoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=D01EGWm0got85yRAy3A4POdu0dEH0fkCaGdS53uYu20=; b=Vw+q+A5r+oIikot3aRtyf234duBVMp76bV6u4SnUXY+6JmpTGoTRMRvbYwJx7i0UN9 pXxxm9y93xw9qJpSjJw5Hisune2rQx8jA6f6lyvNXHrnxzf7a4uQ7qcdWfw9ge3JRsna ePKvkx7GwUVqE5Kn5hTkbiwfkdp/hgPmjiXp2cuXgpuobcb+Vr7hsRi+NcEfF+pJF3kU pR6T3QJASZzlLojXzXfmVRYulTLSoi792LlPqx5CIgRlvRDma33oxdVDtwEfbcNGoWY5 nYGweGbUIMDAJOC69A55QtdAiyeGtBJ5dj4msip+469ZAQB0VOFjBeypG5fKr8wzPk89 ob4A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f203si18237501oib.56.2020.01.20.10.10.56; Mon, 20 Jan 2020 10:11:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727071AbgATSJu (ORCPT + 99 others); Mon, 20 Jan 2020 13:09:50 -0500 Received: from foss.arm.com ([217.140.110.172]:35374 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726642AbgATSJu (ORCPT ); Mon, 20 Jan 2020 13:09:50 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4DBE031B; Mon, 20 Jan 2020 10:09:47 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BEFD43F68E; Mon, 20 Jan 2020 10:09:46 -0800 (PST) Date: Mon, 20 Jan 2020 18:09:45 +0000 From: Mark Brown To: Ben Whitten Cc: linux-kernel@vger.kernel.org, afaerber@suse.de, Greg Kroah-Hartman , "Rafael J. Wysocki" Subject: Re: [PATCH v2 2/2] regmap: stop splitting writes to non incrementing registers Message-ID: <20200120180945.GL6852@sirena.org.uk> References: <20200118205625.14532-1-ben.whitten@gmail.com> <20200118205625.14532-2-ben.whitten@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="B92bTrfKjyax39gr" Content-Disposition: inline In-Reply-To: <20200118205625.14532-2-ben.whitten@gmail.com> X-Cookie: I invented skydiving in 1989! User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --B92bTrfKjyax39gr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Jan 18, 2020 at 08:56:25PM +0000, Ben Whitten wrote: > When writing to non incrementing registers we should not split > the writes in any way, writing in one transaction. That's not an obviously true statement. If the user is intentionally writing to a non-incrementing register and intends to stuff a block of data into that one register via regmap_noinc_write() then sure but if we've come in through a path that isn't specifically for the device or is using one of the generic APIs then it's going to expect that the framework will hide the unfortunate choices of the chip implementors and split the I/O up. --B92bTrfKjyax39gr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl4l7OgACgkQJNaLcl1U h9B15Qf/eSKG10E4bNRPd6i40jrJnX38xv0NgOBdEXse9NCOM4GO/nOlN8181OPu I4WJUiOUbsUCvfe355DjI717UgUCfUk3e85UpfOl3DS2/wT0tFzhGb2KHhsUXvWW /CRk+Wft/YX107oEBhTitJW7AaUfN2p5qwFCFvIEBi3eUPDdqbblpDbDfXrlzzfX 61v73NlEeQPRWv1yELBpdrOG9vM/8mJP3tMLLjxOSmdexYODKW6vbkVsRBHpef5/ LgkDTAFcFawODctD/TiZBY6vYGul30E7e9jGjZUOWhE+mH0JjJkWi6z6NAWMAJt1 jNFXHMKT2h4LZgepfx53dc+xGdsOZw== =MhbO -----END PGP SIGNATURE----- --B92bTrfKjyax39gr--