Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2876027ybl; Mon, 20 Jan 2020 11:05:00 -0800 (PST) X-Google-Smtp-Source: APXvYqzgh2Wo3xzohRThQZOuZbq9MrTbAvvMeUQT3vdGj+q0znwQYs2DoY52hWnVi6D+OG+4AxRd X-Received: by 2002:aca:cdd6:: with SMTP id d205mr241238oig.90.1579547100706; Mon, 20 Jan 2020 11:05:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579547100; cv=none; d=google.com; s=arc-20160816; b=J+S6HxR/MsehLucrO77n2LVdJLtkL7fB6XFDYLXQ28vPgELf4r37JsB5A3zAQz4M8h RI0eE4mVgYdwFm2ui75hwwcvpJUslcYF/LU0uzCKB/dfP2THaZaRJN8mEXJABbNVpS9T KPgk8/iZykhzaYl184UIrscuGci7q9nPiMiO5E2F6fgshnojmkQ8wGBKMr7QGYWRlBB1 g963yqL82L0ddug716gr5ltCCNDhzlHoidF/dM6bMQ+cSRYuHQ9yGIEZx4lIh8NFUD9A UpTIF9jt78fjpjUExwYyu+JAeovK51Fm4FTo2vOd6wlmu2rYUGwVJCuboBs57j8WAaxf iBSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from; bh=7/FKVjD/Eon6cI0Ec9m82kzmBAVCG6MS4KxrnOEUmtA=; b=j7X1Yn2TOire9WPnb0G4iXiA/OqxCNsz381oEIdQ7V1hEZWurlgSAHTf94G9OpY3GL ByweWIaP87PRTulSUG2C/+6ajWM0RLg7hrxLs4Vz3bK2xxE9sgXVLZSLsgnPClAHvbuo oLoyYUILOGx6XuGTzpi6jmnDYalO4otBfPNOdniGhfUj6UtcBqMi1ZPny7hxaNmk5897 FvFJpqNtR49gc3TZTCN9kUPri/tlxIydyt3incu7ENCOoQ5mX3oIsYfsgMM2rDsX052J LMxiGbIvACWfM+rWo9L8rLgmbFNt6GF6A8BcYitmwXJX+3XcJQglzNwkBcZo7b1n8j6K PGOw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t3si19040287oig.25.2020.01.20.11.04.37; Mon, 20 Jan 2020 11:05:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727041AbgATTDB (ORCPT + 99 others); Mon, 20 Jan 2020 14:03:01 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:34141 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726112AbgATTDB (ORCPT ); Mon, 20 Jan 2020 14:03:01 -0500 Received: from p5b06da22.dip0.t-ipconnect.de ([91.6.218.34] helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1itcK7-0006Ja-EC; Mon, 20 Jan 2020 20:02:55 +0100 Received: by nanos.tec.linutronix.de (Postfix, from userid 1000) id BCE58105BE6; Mon, 20 Jan 2020 20:02:54 +0100 (CET) From: Thomas Gleixner To: Anthony Steinhauser , linux-kernel@vger.kernel.org Cc: mingo@redhat.com, bp@alien8.de, Anthony Steinhauser Subject: Re: [PATCH] Return ENXIO instead of EPERM when speculation control is unimplemented In-Reply-To: <20191229164830.62144-1-asteinhauser@google.com> References: <20191229164830.62144-1-asteinhauser@google.com> Date: Mon, 20 Jan 2020 20:02:54 +0100 Message-ID: <87o8uy2boh.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Anthony, Anthony Steinhauser writes: > return ""; > > switch (spectre_v2_user) { > - case SPECTRE_V2_USER_NONE: > + case SPECTRE_V2_USER_UNAVAILABLE: > + return ", STIBP: unavailable"; Shouldn't this for correctness differentiate between the case where the STIBP mitigation feature is not available and the case where STIBP is not used because SMT is not possible? Thanks, tglx