Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2 bpf-next] bpf: Fix memory leaks in generic
 update/delete batch ops
To:     Brian Vazquez <brianvv@google.com>,
        Brian Vazquez <brianvv.kernel@gmail.com>,
        Alexei Starovoitov <ast@kernel.org>,
        "David S . Miller" <davem@davemloft.net>
Cc:     linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        bpf@vger.kernel.org, Dan Carpenter <dan.carpenter@oracle.com>,
        Yonghong Song <yhs@fb.com>
References: <20200119194040.128369-1-brianvv@google.com>
From:   Daniel Borkmann <daniel@iogearbox.net>
Message-ID: <39e16779-39e8-3dd3-455e-949b6bd04de9@iogearbox.net>
Date:   Mon, 20 Jan 2020 22:39:21 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <20200119194040.128369-1-brianvv@google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 1/19/20 8:40 PM, Brian Vazquez wrote:
> generic update/delete batch ops functions were using __bpf_copy_key
> without properly freeing the memory. Handle the memory allocation and
> copy_from_user separately.
> 
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Fixes: aa2e93b8e58e ("bpf: Add generic support for update and delete batch ops")
> Signed-off-by: Brian Vazquez <brianvv@google.com>
> Acked-by: Yonghong Song <yhs@fb.com>

Applied, thanks!